-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard dialog updates for both visual and accessible content #214
Comments
Implemented above, please review. |
@zepumph, sorry I missed one detail for the KB Shortcuts dialog.
A11y Content for these same items
I don't know if there is an option for this, or if you handle it manually. It would be good to have an option as not all sims have groups in them. Also, it seems like we have some inconsistency. At the moment BASE has "or group" in the visual dialog, but not in the A11y content and MAL is missing the "or group" wording in both places. Note there is no corresponding visual for the "Move through items in a group". I will reach out to Emily and Amy about that. I can't remember if there was a decision not to have that. I'll update the text in the design doc. Sorry, I missed this. |
We do have an option, see the commit above (very easy thanks to @jessegreenberg). I also did this for CL. How does that sound? I can make further changes, but they would be in common code. If you think that something should change from how it is in CL and GFL right now, then I would recommend making an issue about it in |
@zepumph, nice there was an option, but I don't see the added words "item or group" in the A11y View of the dialog. Should this comment move over to scenery-phet?
AND ONE more visual thing
|
I removed the extra jump, I also fixed a regression where the group content was showing up in BASICS, and I created phetsims/scenery-phet#570 for solving the addition of group related strings generally (which has been implemented and is out for review). @terracoda anything else here? |
All verified. Closing. |
@zepumph, just noticed a few updates that will be needed for KB dialog:
Updates to Visuals:
Updates to A11y Strings for Keyboard Dialog
The text was updated successfully, but these errors were encountered: