Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard dialog updates for both visual and accessible content #214

Closed
terracoda opened this issue Nov 27, 2019 · 6 comments
Closed

Keyboard dialog updates for both visual and accessible content #214

terracoda opened this issue Nov 27, 2019 · 6 comments

Comments

@terracoda
Copy link
Contributor

@zepumph, just noticed a few updates that will be needed for KB dialog:

Updates to Visuals:

  • Change order of Move and Jump details (heading and list items)
  • Insert "and release ruler" in the [J]+[H] instructions block.
    Screen Shot 2019-11-27 at 1 47 02 PM

Updates to A11y Strings for Keyboard Dialog

  • remove "the" in first line under "Move Spheres", the bullet item reads:
    • "Move sphere left and right with Left and Right Arrow keys."
  • Reverse order of "Move" and "Jump" in heading for moving ruler
    • change to: "Jump or Move Grabbed Ruler"
  • Insert "and release ruler" to JH instructions
    • change to: "Jump and release ruler to home position with J plus H. "
  • Reorder the bullets, the last two are first and the first two are last (see adjusted screenshot)

Screen Shot 2019-11-27 at 1 46 36 PM

@zepumph
Copy link
Member

zepumph commented Jan 1, 2020

Implemented above, please review.

@terracoda
Copy link
Contributor Author

@zepumph, sorry I missed one detail for the KB Shortcuts dialog.
We now have a radio button group.
We need to use the Basic Actions options that include the words "or group" like in BASE:

  • Move to next item or group [Tab]
  • Move to previous item or group with [Shift] + [Tab]

A11y Content for these same items

  • Move to next item or group with Tab key.
  • Move to previous item or group with Shift plus Tab key.
  • Move through items in a group with Up and Down arrow keys.

I don't know if there is an option for this, or if you handle it manually. It would be good to have an option as not all sims have groups in them. Also, it seems like we have some inconsistency. At the moment BASE has "or group" in the visual dialog, but not in the A11y content and MAL is missing the "or group" wording in both places.

Note there is no corresponding visual for the "Move through items in a group". I will reach out to Emily and Amy about that. I can't remember if there was a decision not to have that.

I'll update the text in the design doc. Sorry, I missed this.

@zepumph
Copy link
Member

zepumph commented Jan 7, 2020

I don't know if there is an option for this

We do have an option, see the commit above (very easy thanks to @jessegreenberg).

I also did this for CL. How does that sound? I can make further changes, but they would be in common code. If you think that something should change from how it is in CL and GFL right now, then I would recommend making an issue about it in scenery-phet and it can apply to all sims.

zepumph added a commit that referenced this issue Jan 7, 2020
@zepumph zepumph assigned terracoda and unassigned zepumph Jan 7, 2020
zepumph added a commit to phetsims/coulombs-law that referenced this issue Jan 7, 2020
@terracoda
Copy link
Contributor Author

terracoda commented Jan 8, 2020

@zepumph, nice there was an option, but I don't see the added words "item or group" in the A11y View of the dialog. Should this comment move over to scenery-phet?

AND ONE more visual thing

  • I just noticed an extra "Jump or" string in the visual dialog, please remove.

Screen Shot 2020-01-08 at 6 56 58 PM

@zepumph
Copy link
Member

zepumph commented Jan 9, 2020

I removed the extra jump, I also fixed a regression where the group content was showing up in BASICS, and I created phetsims/scenery-phet#570 for solving the addition of group related strings generally (which has been implemented and is out for review).

@terracoda anything else here?

@terracoda
Copy link
Contributor Author

All verified. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants