-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerts cut out when VO highlight changes #196
Comments
Someone with a mac will need to investigate this, I can look into this, potentially pairing with @zepumph if we have time. |
We didn't have time! Unassigning, but let me know @jessegreenberg if you would like assistance. Thanks for the help. |
I am getting alert cut-out on iOS VoiceOver. I am not getting cut outs in RIAW so it is something specific to the way this sim works. I am not sure yet if it is caused by PDOM positioning, the cut out on iPad Air 2 is a bit after the black VO highlight moves. |
@jessegreenberg, do you think it would make a difference if we used |
Yes that is definitely possible. But before changing that I would like to see if we can understand why this is happening for the sliders in this sim and not the sliders in other sims. |
@jessegreenberg and @zepumph, I just noticed in the PhET App for GFL Basics no interruptions happen. The responses are not getting cut off for GFLB even though the VoiceOver's cursor takes a bit of time to catch up to the changed position of the moved mass sphere. Maybe the cut-off is not related to the cursor's delay? |
I am no longer getting this behavior and I am wondering if this was also fixed by phetsims/utterance-queue@0f04791 |
I reverted the change and the issue returned pretty consistently. So I think this has been fixed. Ill make a new version for @terracoda to verify. |
@terracoda can you please verify that this is fixed in https://phet-dev.colorado.edu/html/gravity-force-lab/2.2.0-dev.22/phet/gravity-force-lab_en_phet.html?a11y&supportsSound&supportsEnhancedSound? |
Responses are no longer being cut off! |
@jessegreenberg, it sounds really good. I'll close this issue. |
From #140 (comment), @terracoda found that position and mass alerts (mainly and consistently position alerts) would cut off because the VO highlight would be delayed in how it updates, and when it moved, the alert would be half way read through, and its movement would cause the alert to stop reading. Perhaps this has something to do with #194, but I'm not totally sure.
The text was updated successfully, but these errors were encountered: