Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts cut out when VO highlight changes #196

Closed
zepumph opened this issue Nov 11, 2019 · 12 comments
Closed

Alerts cut out when VO highlight changes #196

zepumph opened this issue Nov 11, 2019 · 12 comments

Comments

@zepumph
Copy link
Member

zepumph commented Nov 11, 2019

From #140 (comment), @terracoda found that position and mass alerts (mainly and consistently position alerts) would cut off because the VO highlight would be delayed in how it updates, and when it moved, the alert would be half way read through, and its movement would cause the alert to stop reading. Perhaps this has something to do with #194, but I'm not totally sure.

@jessegreenberg
Copy link
Contributor

Someone with a mac will need to investigate this, I can look into this, potentially pairing with @zepumph if we have time.

@zepumph
Copy link
Member Author

zepumph commented Nov 19, 2019

We didn't have time! Unassigning, but let me know @jessegreenberg if you would like assistance. Thanks for the help.

@jessegreenberg
Copy link
Contributor

I tested for about 5 minutes on a macOS Safari with VoiceOver and didn't see this happen. I did notice that the VoiceOver highlight doesn't update with the DOM element, and I verified that the DOM element is getting positioned correctly:
Screen Shot 2019-12-03 at 6 30 44 PM

See the blue selection as safari indicates where the DOM element is, and the black VoiceOver highlight around where it was on focus.

Ill try on iOS VoiceOver next, maybe the issue is there.

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Dec 3, 2019

I am getting alert cut-out on iOS VoiceOver. I am not getting cut outs in RIAW so it is something specific to the way this sim works. I am not sure yet if it is caused by PDOM positioning, the cut out on iPad Air 2 is a bit after the black VO highlight moves.

@terracoda
Copy link
Contributor

@jessegreenberg, do you think it would make a difference if we used aria-live="assertive".

@jessegreenberg
Copy link
Contributor

Yes that is definitely possible. But before changing that I would like to see if we can understand why this is happening for the sliders in this sim and not the sliders in other sims.

@terracoda
Copy link
Contributor

@jessegreenberg and @zepumph, I just noticed in the PhET App for GFL Basics no interruptions happen.

The responses are not getting cut off for GFLB even though the VoiceOver's cursor takes a bit of time to catch up to the changed position of the moved mass sphere. Maybe the cut-off is not related to the cursor's delay?

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Dec 10, 2019

I am no longer getting this behavior and I am wondering if this was also fixed by phetsims/utterance-queue@0f04791

@jessegreenberg
Copy link
Contributor

I reverted the change and the issue returned pretty consistently. So I think this has been fixed. Ill make a new version for @terracoda to verify.

@jessegreenberg
Copy link
Contributor

@terracoda
Copy link
Contributor

Responses are no longer being cut off!

@terracoda
Copy link
Contributor

@jessegreenberg, it sounds really good. I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants