Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Credits #180

Closed
zepumph opened this issue Oct 8, 2019 · 9 comments
Closed

QA Credits #180

zepumph opened this issue Oct 8, 2019 · 9 comments

Comments

@zepumph
Copy link
Member

zepumph commented Oct 8, 2019

When the time comes, it is here.

@terracoda
Copy link
Contributor

@zepumph , and A11y Team credits are mentioned in the issue #109

@zepumph
Copy link
Member Author

zepumph commented Jan 7, 2020

@terracoda those were implemented above, now all that is left is QA credits.

@terracoda
Copy link
Contributor

@zepumph, in the Team list, I think the names are supposed to alphabetical, which would put Amy Rouinfar before my name.

When you change, please make sure my name doesn't get split on a wrapped line (thanks).

@terracoda
Copy link
Contributor

Not sure if we have any general preferences for not splitting names, I see Amy's and Brian's names are split.

@zepumph
Copy link
Member Author

zepumph commented Jan 8, 2020

In general it just splits on any space. Do you want me to make an issue to discuss only splitting on full names?

zepumph added a commit that referenced this issue Jan 8, 2020
@terracoda
Copy link
Contributor

Yes, I think it would be nice to not split the names, if it is straightforward.

@zepumph
Copy link
Member Author

zepumph commented Jan 28, 2020

if it is straightforward.

I poked around in RichText, and I'm sorry to say it didn't look easy or straightforward at all. I created phetsims/joist#598 to make sure, but I don't think that we will end up changing anything (sorry!).

Over to @KatieWoe since the sim is now in RC.

@zepumph zepumph assigned KatieWoe and unassigned zepumph Jan 28, 2020
@KatieWoe
Copy link
Contributor

New credits for rc.1:
Jaspe Arias, Logan Bray, Liam Mulhall, Kathryn Woessner

@zepumph
Copy link
Member Author

zepumph commented Mar 6, 2020

I didn't get any updates through rc.2-4 so I'm going to assume that these are good to go. Thanks! Closing!

@zepumph zepumph closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants