PhET-iO Tweaks

[zepumph]

From feedback from a client and another design meeting:

• Higher priority of Recenter NumberControl title when changed with PhET-iO? scenery-phet#526
• Instrument ISLCObjectNode.js
• Add a stroke to mass node texts, and increase the max width to allow for an "increase of font size" for longer strings like "Planet 1." see Updates to ISLCObjectNode's label text inverse-square-law-common#79

[zepumph]

Here is a patch for some of this work:

Index: inverse-square-law-common/js/view/TextWithShadow.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- inverse-square-law-common/js/view/TextWithShadow.js	(date 1566592619000)
+++ inverse-square-law-common/js/view/TextWithShadow.js	(date 1567719293641)
@@ -30,7 +30,7 @@
 
       options = _.extend( {
         labelFill: '#fff',
-        labelFont: new PhetFont( 12 ),
+        labelFont: new PhetFont( 24 ),
         labelMaxWidth: LABEL_MAX_WIDTH,
 
         // options for the label 'shadow' that helps the label show up when the object is roughly the same color
@@ -53,12 +53,14 @@
         centerX: LABEL_CENTER_X + options.labelShadowOffsetX,
         top: LABEL_TOP + options.labelShadowOffsetY
       } );
-      this.addChild( labelShadowText );
+      // this.addChild( labelShadowText );
 
       // add the label
-      const labelText = new RichText( label, {
+      const labelText = new RichText( 'Planet one', {
         font: options.labelFont,
         fill: options.labelFill,
+        lineWidth: .001,
+        stroke: 'black',
         pickable: false,
         maxWidth: options.labelMaxWidth,
         centerX: LABEL_CENTER_X,
Index: inverse-square-law-common/js/view/ISLCObjectNode.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- inverse-square-law-common/js/view/ISLCObjectNode.js	(date 1566592619000)
+++ inverse-square-law-common/js/view/ISLCObjectNode.js	(date 1567717943298)
@@ -108,7 +108,8 @@
     assert && assert( alertManager instanceof ISLCAlertManager );
 
     Node.call( this, {
-      containerTagName: 'div'
+      containerTagName: 'div',
+      tandem: config.tandem
     } );
 
     this.accessibleName = PositionDescriber.getObjectLabelPositionText( config.label );
Index: gravity-force-lab/js/phet-io/gravity-force-lab-phet-io-elements-baseline.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- gravity-force-lab/js/phet-io/gravity-force-lab-phet-io-elements-baseline.js	(revision 7f3203a104af39298d30f01fadeff0dbffeaf7b9)
+++ gravity-force-lab/js/phet-io/gravity-force-lab-phet-io-elements-baseline.js	(date 1567719041716)
@@ -1057,6 +1057,18 @@
       "phetioStudioControl": true,
       "phetioTypeName": "NodeIO"
     },
+    "gravityForceLab.gravityForceLabScreen.view.mass1Node": {
+      "phetioDocumentation": "",
+      "phetioDynamicElement": false,
+      "phetioEventType": "MODEL",
+      "phetioFeatured": false,
+      "phetioHighFrequency": false,
+      "phetioPlayback": false,
+      "phetioReadOnly": false,
+      "phetioState": false,
+      "phetioStudioControl": true,
+      "phetioTypeName": "NodeIO"
+    },
     "gravityForceLab.gravityForceLabScreen.view.mass1Node.centerOfMassLineNode": {
       "phetioDocumentation": "",
       "phetioDynamicElement": false,
@@ -1297,6 +1309,30 @@
       "phetioStudioControl": true,
       "phetioTypeName": "PropertyIO.<BooleanIO>"
     },
+    "gravityForceLab.gravityForceLabScreen.view.mass1Node.opacityProperty": {
+      "phetioDocumentation": "Opacity of the parent NodeIO, between 0 (invisible) and 1 (fully visible)",
+      "phetioDynamicElement": false,
+      "phetioEventType": "MODEL",
+      "phetioFeatured": false,
+      "phetioHighFrequency": false,
+      "phetioPlayback": false,
+      "phetioReadOnly": false,
+      "phetioState": true,
+      "phetioStudioControl": true,
+      "phetioTypeName": "NumberPropertyIO"
+    },
+    "gravityForceLab.gravityForceLabScreen.view.mass1Node.pickableProperty": {
+      "phetioDocumentation": "Sets whether the node will be pickable (and hence interactive), see the NodeIO documentation for more details",
+      "phetioDynamicElement": false,
+      "phetioEventType": "MODEL",
+      "phetioFeatured": false,
+      "phetioHighFrequency": false,
+      "phetioPlayback": false,
+      "phetioReadOnly": false,
+      "phetioState": true,
+      "phetioStudioControl": true,
+      "phetioTypeName": "PropertyIO.<NullableIO.<BooleanIO>>"
+    },
     "gravityForceLab.gravityForceLabScreen.view.mass1Node.textProperty": {
       "phetioDocumentation": "The text located on the puller object",
       "phetioDynamicElement": false,
@@ -1309,6 +1345,30 @@
       "phetioStudioControl": true,
       "phetioTypeName": "PropertyIO.<StringIO>"
     },
+    "gravityForceLab.gravityForceLabScreen.view.mass1Node.visibleProperty": {
+      "phetioDocumentation": "Controls whether the Node will be visible (and interactive), see the NodeIO documentation for more details.",
+      "phetioDynamicElement": false,
+      "phetioEventType": "MODEL",
+      "phetioFeatured": false,
+      "phetioHighFrequency": false,
+      "phetioPlayback": false,
+      "phetioReadOnly": false,
+      "phetioState": true,
+      "phetioStudioControl": true,
+      "phetioTypeName": "PropertyIO.<BooleanIO>"
+    },
+    "gravityForceLab.gravityForceLabScreen.view.mass2Node": {
+      "phetioDocumentation": "",
+      "phetioDynamicElement": false,
+      "phetioEventType": "MODEL",
+      "phetioFeatured": false,
+      "phetioHighFrequency": false,
+      "phetioPlayback": false,
+      "phetioReadOnly": false,
+      "phetioState": false,
+      "phetioStudioControl": true,
+      "phetioTypeName": "NodeIO"
+    },
     "gravityForceLab.gravityForceLabScreen.view.mass2Node.centerOfMassLineNode": {
       "phetioDocumentation": "",
       "phetioDynamicElement": false,
@@ -1549,6 +1609,30 @@
       "phetioStudioControl": true,
       "phetioTypeName": "PropertyIO.<BooleanIO>"
     },
+    "gravityForceLab.gravityForceLabScreen.view.mass2Node.opacityProperty": {
+      "phetioDocumentation": "Opacity of the parent NodeIO, between 0 (invisible) and 1 (fully visible)",
+      "phetioDynamicElement": false,
+      "phetioEventType": "MODEL",
+      "phetioFeatured": false,
+      "phetioHighFrequency": false,
+      "phetioPlayback": false,
+      "phetioReadOnly": false,
+      "phetioState": true,
+      "phetioStudioControl": true,
+      "phetioTypeName": "NumberPropertyIO"
+    },
+    "gravityForceLab.gravityForceLabScreen.view.mass2Node.pickableProperty": {
+      "phetioDocumentation": "Sets whether the node will be pickable (and hence interactive), see the NodeIO documentation for more details",
+      "phetioDynamicElement": false,
+      "phetioEventType": "MODEL",
+      "phetioFeatured": false,
+      "phetioHighFrequency": false,
+      "phetioPlayback": false,
+      "phetioReadOnly": false,
+      "phetioState": true,
+      "phetioStudioControl": true,
+      "phetioTypeName": "PropertyIO.<NullableIO.<BooleanIO>>"
+    },
     "gravityForceLab.gravityForceLabScreen.view.mass2Node.textProperty": {
       "phetioDocumentation": "The text located on the puller object",
       "phetioDynamicElement": false,
@@ -1561,6 +1645,18 @@
       "phetioStudioControl": true,
       "phetioTypeName": "PropertyIO.<StringIO>"
     },
+    "gravityForceLab.gravityForceLabScreen.view.mass2Node.visibleProperty": {
+      "phetioDocumentation": "Controls whether the Node will be visible (and interactive), see the NodeIO documentation for more details.",
+      "phetioDynamicElement": false,
+      "phetioEventType": "MODEL",
+      "phetioFeatured": false,
+      "phetioHighFrequency": false,
+      "phetioPlayback": false,
+      "phetioReadOnly": false,
+      "phetioState": true,
+      "phetioStudioControl": true,
+      "phetioTypeName": "PropertyIO.<BooleanIO>"
+    },
     "gravityForceLab.gravityForceLabScreen.view.massControl1": {
       "phetioDocumentation": "",
       "phetioDynamicElement": false,
Index: gravity-force-lab/js/phet-io/gravity-force-lab-phet-io-types.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- gravity-force-lab/js/phet-io/gravity-force-lab-phet-io-types.js	(revision 7f3203a104af39298d30f01fadeff0dbffeaf7b9)
+++ gravity-force-lab/js/phet-io/gravity-force-lab-phet-io-types.js	(date 1567719041761)

[zepumph]

Original instrumentation issue: #76

[zepumph]

Instrumented ISLCObjectNode above. Everything else will be handled in their own issues. Closing