Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove meter mark and adjust phrasing in Sphere descriptions #169

Closed
terracoda opened this issue Jul 24, 2019 · 4 comments
Closed

Remove meter mark and adjust phrasing in Sphere descriptions #169

terracoda opened this issue Jul 24, 2019 · 4 comments

Comments

@terracoda
Copy link
Contributor

terracoda commented Jul 24, 2019

Based on changes made in GFL Basics and decision in #168, I have some adjustments to the dynmaic state descriptions for the mass spheres in the Play Area.

Please see Table: Examples - Dynamic state descriptions m1 & m2

Here's the old and new example for m1, Blue Sphere with Force Values checked:
m1, Blue Sphere (old)

  • Force on ‪m1‬ by ‪m2‬ is small, and vector points directly at ‪m2‬.
  • Force vector magnitude is 0.166852 micronewtons.
  • ‪m1‬ is very small at 100 kilograms and at 2.8 ‪meter‬ mark.

m1, Blue Sphere (new)

  • Force vector is {{small}}, and points directly at ‪{{m2}}‬.
  • Force magnitude on m2 by m1 is {{0.166852 }} micronewtons.
  • ‪m1‬ is {{100}} kilograms, {{much much smaller than}} m2, and also {{4}} meters from ‪m2.

All other examples showing the different states depending on which checkboxes are checked are in the design doc in Table: Examples - Dynamic state descriptions m1 & m2.

Edits

  • Sept 24, 2019 - Changed values to reflect new values on page load!
@terracoda
Copy link
Contributor Author

@zepumph, this might be a repeat issue of #160 (comment) (apologies)

@zepumph
Copy link
Member

zepumph commented Sep 30, 2019

Before I start this work, here is a snippet of GFLB, so I can regression test:

image

zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Sep 30, 2019
zepumph added a commit to phetsims/gravity-force-lab-basics that referenced this issue Sep 30, 2019
zepumph added a commit to phetsims/gravity-force-lab-basics that referenced this issue Sep 30, 2019
@zepumph
Copy link
Member

zepumph commented Sep 30, 2019

This has been implemented. @terracoda please review. Specifically please focus on the following items

  • Please check that the two object labels (like on m1 by m2) is correct and not backwards
  • Make sure that they update to changes in the sim as expected (especially the control panel checkboxes)

Thanks!

@terracoda
Copy link
Contributor Author

Looks good @zepumph! Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants