Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to PDOM Order: Move Grab Ruler (ruler) to just before Rest All button. #158

Closed
terracoda opened this issue Jun 28, 2019 · 4 comments

Comments

@terracoda
Copy link
Contributor

@zepumph, this change refers only to the PDOM order. There is no change the visual simulation.

Reasoning:

  • Non-visual users get distance information directly from the position sliders (move m1, move m2).
  • The ruler interaction is not important for non-visual access. We are placing it last in the Control Area to discourage its use by non-visual users.

If needed see Heading Outline & Focus Order in design doc.

@terracoda
Copy link
Contributor Author

@zepumph this issue is dependent on decision in #156.

@terracoda
Copy link
Contributor Author

@zepumph, in #156, @arouinfar and I agreed that providing quantitative distance was the best way to provide the distance value to non-visual users.

This means we should indeed change the focus order of the grab ruler button, so that it comes just before the Reset All button. The visual placement of the ruler does not move, just when the grab ruler/ruler receive focus.

This will means there is a smooth transition between interacting with the move sphere sliders and the mass changing sliders.

zepumph added a commit that referenced this issue Jul 30, 2019
…ddChild` directly to PDOM nodes, to setting the PDOM node's accessibleOrder, see #158
@zepumph
Copy link
Member

zepumph commented Jul 30, 2019

This has been done above. The change pulled the visual scene graph order from the PDOM order, instead using accessibleOrder to set the PDOM order. This was important because the RulerNode is carefully layered in the sim to visually go on top of the masses, but below all the controls. @terracoda please review.

@terracoda
Copy link
Contributor Author

@zepumph, looks good. And I think it sounds good at the end because, it's almost like a reminder to go back and play with distance.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants