-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to PDOM Order: Move Grab Ruler (ruler) to just before Rest All button. #158
Comments
@zepumph, in #156, @arouinfar and I agreed that providing quantitative distance was the best way to provide the distance value to non-visual users. This means we should indeed change the focus order of the grab ruler button, so that it comes just before the Reset All button. The visual placement of the ruler does not move, just when the grab ruler/ruler receive focus. This will means there is a smooth transition between interacting with the move sphere sliders and the mass changing sliders. |
…ddChild` directly to PDOM nodes, to setting the PDOM node's accessibleOrder, see #158
This has been done above. The change pulled the visual scene graph order from the PDOM order, instead using accessibleOrder to set the PDOM order. This was important because the RulerNode is carefully layered in the sim to visually go on top of the masses, but below all the controls. @terracoda please review. |
@zepumph, looks good. And I think it sounds good at the end because, it's almost like a reminder to go back and play with distance. Closing. |
@zepumph, this change refers only to the PDOM order. There is no change the visual simulation.
Reasoning:
If needed see Heading Outline & Focus Order in design doc.
The text was updated successfully, but these errors were encountered: