update positionProperty range and documentation, #172

phetsims · Jan 7, 2020 · e670f4e · e670f4e
1 parent c270ec6
commit e670f4e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/js/model/GravityForceLabModel.js b/js/model/GravityForceLabModel.js
@@ -24,6 +24,12 @@ define( require => {
   const Vector2 = require( 'DOT/Vector2' );
   const Vector2Property = require( 'DOT/Vector2Property' );
 
+  // constants
+  const MASS_OPTIONS = {
+    leftObjectBoundary: GravityForceLabConstants.PULL_LOCATION_RANGE.min,
+    rightObjectBoundary: GravityForceLabConstants.PULL_LOCATION_RANGE.max
+  };
+
   /**
    * @param {Tandem} tandem
    * @constructor
@@ -55,9 +61,9 @@ define( require => {
     const density = 150; // in kg/m^3
 
     const mass1 = new Mass( massValue1, position1, GravityForceLabConstants.MASS_RANGE, density,
-      this.constantRadiusProperty, baseColor1, tandem.createTandem( 'mass1' ) );
+      this.constantRadiusProperty, baseColor1, tandem.createTandem( 'mass1' ), MASS_OPTIONS );
     const mass2 = new Mass( massValue2, position2, GravityForceLabConstants.MASS_RANGE, density,
-      this.constantRadiusProperty, baseColor2, tandem.createTandem( 'mass2' ) );
+      this.constantRadiusProperty, baseColor2, tandem.createTandem( 'mass2' ), MASS_OPTIONS );
 
     // leverage ISLCModel, in "mass" mode
     ISLCModel.call( this, PhysicalConstants.GRAVITATIONAL_CONSTANT, mass1, mass2,

diff --git a/js/phet-io/gravity-force-lab-phet-io-elements-baseline.js b/js/phet-io/gravity-force-lab-phet-io-elements-baseline.js
@@ -1562,7 +1562,7 @@ window.phet.phetio.phetioElementsBaseline = assert &&
       "phetioTypeName": "PropertyIO<RangeIO>"
     },
     "gravityForceLab.gravityForceLabScreen.model.mass1.positionProperty": {
-      "phetioDocumentation": "The position of the object along the track, in meters.",
+      "phetioDocumentation": "The position of the object along the track, in meters. The origin is in the center between the two objects.",
       "phetioDynamicElement": false,
       "phetioEventType": "MODEL",
       "phetioFeatured": false,
@@ -1614,7 +1614,7 @@ window.phet.phetio.phetioElementsBaseline = assert &&
       "phetioTypeName": "PropertyIO<RangeIO>"
     },
     "gravityForceLab.gravityForceLabScreen.model.mass2.positionProperty": {
-      "phetioDocumentation": "The position of the object along the track, in meters.",
+      "phetioDocumentation": "The position of the object along the track, in meters. The origin is in the center between the two objects.",
       "phetioDynamicElement": false,
       "phetioEventType": "MODEL",
       "phetioFeatured": false,