Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Still hear "Vectors" in force alert on last stop #98

Closed
terracoda opened this issue Feb 20, 2019 · 4 comments
Closed

Still hear "Vectors" in force alert on last stop #98

terracoda opened this issue Feb 20, 2019 · 4 comments
Assignees
@terracoda
Labels
priority:3-medium status:ready-for-review

Comments

@terracoda
Copy link

Creating an issue for this straggling occurrence of "vectors". It seems kind of persistent.

It seems to only happen in the force alert when a sphere reaches the last stop.
screen shot 2019-02-20 at 7 31 02 am
screen shot 2019-02-20 at 7 26 33 am
@terracoda
Copy link
Author

This issue was original listed in issue #88.

@terracoda
Copy link
Author

@zepumph, I don't think this gets in the way too much. Please fix if there is time after the distance issues are implemented.

zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Feb 26, 2019
@zepumph
convert one more Vectors -> Force Arrows, phetsims/gravity-force-lab-…
bbfb8b6 
…basics#98
@zepumph
Copy link
Member

zepumph commented Feb 26, 2019

Ugh! Sorry for your patience, I think this is the last one. I looked through all usages of "Vector" in the common ISLC code and didn't see any more. How about that?

@zepumph zepumph assigned terracoda and unassigned zepumph Feb 26, 2019
@terracoda
Copy link
Author

No apologies necessary. It was a slippery fish! I think you finally hooked it.

@zepumph zepumph mentioned this issue Feb 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terracoda terracoda

Labels
priority:3-medium status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terracoda @zepumph