Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type prefixes should be consistent #54

Closed
jessegreenberg opened this issue Mar 3, 2018 · 0 comments
Closed

Type prefixes should be consistent #54

jessegreenberg opened this issue Mar 3, 2018 · 0 comments
Assignees
@mbarlow12
Labels
dev:code-review

Comments

@jessegreenberg
Copy link
Contributor

For #49.

Most types in this repo have the full "GravityForceLab*" name. GFLBMassNode and GFLBA11yStrings are the two that do not conform. They should either be renamed to GravityForceLabBasicsMassNode and GravityForceLabBasicsA11yStrings respectively, or the other types should be renamed to use the acronym.

Renaming the two would be less work, but renaming the rest would produce more manageable type names. @mbarlow12 can you look into this and do you have a preference?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbarlow12 mbarlow12

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbarlow12 @jessegreenberg