Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Voicing) Voice does not match text in Keyboard Shortcuts menu #298

Closed
Tracked by #729
stemilymill opened this issue Sep 1, 2021 · 9 comments
Closed
Tracked by #729

(Voicing) Voice does not match text in Keyboard Shortcuts menu #298

stemilymill opened this issue Sep 1, 2021 · 9 comments

Comments

@stemilymill
Copy link

phetsims/qa#702
Win10 Firefox

Voicing reads the heading of the "Change Mass" section of the Keyboard Shortcuts menu as "Change Massachusetts"

There is also no pause in between this utterance and the next.

change mass reads change massachussetts

@jessegreenberg
Copy link
Contributor

Thanks for making an issue, this is kind of funny. But certainly not what we want. I was able to see this in Firefox as well. There isn't a way to change the voicing interpretation of the string. I am not sure why Voicing is interpreting "Massachusetts" for the bold and not for other strings. "Change Mass" label next to the arrow keys is read correctly by speech synthesis.

@jessegreenberg
Copy link
Contributor

@terracoda suggested that we make sure there is no punctuation that could trigger this. @emily-phet suggested to see what happens when we do not capitalize the "M".

@stemilymill
Copy link
Author

This is kind of unrelated but I don't know who to tell separately- the "Change Mass" label next to the arrow keys should not have "Mass" capitalized, in order to match the rest of the dialog.

@jessegreenberg
Copy link
Contributor

Thanks @stemilymill , Ill make a new issue for that.

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Sep 15, 2021

It is broken up into sentences for Voicing. So It looks like "Change Mass." which I could see being interpreted as an abbreviation for the state.
image

@jessegreenberg
Copy link
Contributor

Yes, changing to a comma fixes this.

jessegreenberg added a commit to phetsims/scenery-phet that referenced this issue Sep 15, 2021
jessegreenberg added a commit to phetsims/scenery-phet that referenced this issue Sep 15, 2021
jessegreenberg added a commit that referenced this issue Sep 15, 2021
@jessegreenberg
Copy link
Contributor

Change committed and cherry-picked to the 1.1 SHAs.

@terracoda
Copy link

Good catch @jessegreenberg. We'll have to keep this capitalization and punctuation in mind for auditory description displays :-)

@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 2, 2021

Looks ok on Win 11 Firefox+NVDA

@KatieWoe KatieWoe closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants