Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One last missing period. #177

Closed
terracoda opened this issue Sep 24, 2019 · 3 comments
Closed

One last missing period. #177

terracoda opened this issue Sep 24, 2019 · 3 comments

Comments

@terracoda
Copy link

terracoda commented Sep 24, 2019

While double checking description in issue #173 (comment)

I found one missing period in an aria-live alert (a context response), please see red arrow in screenshot below. This alert (context response) occurs when the Constant Size checkbox becomes unchecked.

Please be careful adding in the period. It is important to make sure a period does not pop up in the other underlined areas of the PDOM's dynamic descriptions (see underlined content).

If this is not straightforward, I think we can handle adding this period in a maintenance release.
last-missing-period

@terracoda
Copy link
Author

And this is an issue for GFL regular, too, so this string might live in some common strings place.
Screen Shot 2019-09-24 at 10 46 12 AM

zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Sep 24, 2019
@zepumph
Copy link
Member

zepumph commented Sep 24, 2019

We got lucky here. Though that snippet was in three places in the descriptions, there was a string pattern that only applied to the alert, so I added the period there. Please review before I copy it over to the RC shas. UPDATE: the fix was made in GFL, so it applies to both.

@terracoda
Copy link
Author

Awesome! Looks good @zepumph. Closing issue.
period-fixed

@zepumph zepumph mentioned this issue Sep 26, 2019
7 tasks
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants