-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One last missing period. #177
Labels
Comments
zepumph
added a commit
to phetsims/gravity-force-lab
that referenced
this issue
Sep 24, 2019
We got lucky here. Though that snippet was in three places in the descriptions, there was a string pattern that only applied to the alert, so I added the period there. Please review before I copy it over to the RC shas. UPDATE: the fix was made in GFL, so it applies to both. |
Awesome! Looks good @zepumph. Closing issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While double checking description in issue #173 (comment)
I found one missing period in an aria-live alert (a context response), please see red arrow in screenshot below. This alert (context response) occurs when the Constant Size checkbox becomes unchecked.
Please be careful adding in the period. It is important to make sure a period does not pop up in the other underlined areas of the PDOM's dynamic descriptions (see underlined content).
If this is not straightforward, I think we can handle adding this period in a maintenance release.
The text was updated successfully, but these errors were encountered: