Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tyepdoc for describers #161

Closed
jessegreenberg opened this issue Jun 28, 2019 · 3 comments
Closed

Tyepdoc for describers #161

jessegreenberg opened this issue Jun 28, 2019 · 3 comments
Assignees
@jessegreenberg
Labels
status:ready-for-review

Comments

@jessegreenberg
Copy link
Contributor

@zepumph could you please add typedoc for the files under gravity-force-lab-basics/view/describers?

For #156
@jessegreenberg
Copy link
Contributor Author

Also GFLBAlertManager and the supertypes for a few of these are missing typedoc as well.

@zepumph
Copy link
Member

zepumph commented Jul 1, 2019

How's that?

zepumph added a commit that referenced this issue Jul 1, 2019
@zepumph
add type docs to alert manager and describer subtypes, #161
8926592
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Jul 1, 2019
@zepumph
add type docs to alert manager and describer subtypes, phetsims/gravi…
6102105 
…ty-force-lab-basics#161
@zepumph zepumph assigned jessegreenberg and unassigned zepumph Jul 1, 2019
jessegreenberg added a commit that referenced this issue Jul 1, 2019
@jessegreenberg
author annotations for #161
db51c71
@jessegreenberg
Copy link
Contributor Author

Typedoc was truly added this day. I added author annotations to ensure those props. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph