-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GFLBMassNode to extend MassNode? #150
Comments
@jessegreenberg @twant and I feel pretty good about this. Could you please review for regression, as well as two new points:
|
I changed my mind. I can tell a difference when the stroke is present. I think it looks good in GFLB. @jessegreenberg can you think of a reason that it was purposefully omitted? |
Code looks really nice to me, thanks! I searched through commit history and repo issues in here, GFL, and ISLC and couldn't find anything about lack of stroke. I assume that this visual change is totally great. I actually think it looks better. Closing this issue. |
Discovered as part of #134. This will save code (a real commodity these days) and complexity, especially duplication in
updateGradient
.The text was updated successfully, but these errors were encountered: