-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider descriptions referring to density #149
Comments
Part 1 of issue, the help text:Please consider all descriptions that are trying to support the idea of density without literally describing how density is represented visually (i.e., with shades of Red and Blue). Note that when a user checks or unchecks the Constant Size checkbox, there are two different alerts:
So I am wondering if you prefer that we not change the help text at all (version 2) when Constant Size is checked, or should we use the more accurate description with the unit of volume added (version 3 and 4):
@arouinfar, which of these pairs is your preference for a middle-school sim? Keep in mind, if for Gravity Force Lab (regular) the help text needs to be more precise, the help text can be different between the two sims. |
Part 2 of issue, the alert phrasingDo we need to adjust the alert phrasing when Constant Size checkbox is checked? Current Examples from Design Doc:Note: For slider/number spinner interactions, typically the object response (the new current value) is delivered first (as part of When increasing the mass of a mass sphere from 2 to 3 billion kilograms:
Decreasing mass of a mass sphere from 2 billion kilograms to 1 billion kilogram:
@arouinfar, are you suggesting any changes to the context responses (the alert phrasing), or just the help text? |
@arouinfar, if you would rather meet, just let me know. Once you have commented, please re-assign me ;-) |
@arouinfar, I am most concerned about this comment:
Note that the students we are trying to reach with the density/force alerts cannot see the color changes. And also note that the alert is delivered together with the changed mass value. This may not have been apparent when using the A11y View. It is much more clear when using an actual screen reader, or looking at the examples that I copied in from the design document. |
@terracoda thank you so much for your detailed response! I think I have much better sense of what users will actually hear while interacting with the sim. I also spent some time today playing with dev.39 using VoiceOver. I'm not savvy enough to figure out how to access the help text and everything in the PDOM, but I do believe I was hearing the static descriptions and interactive alerts, including things very similar to the examples in #149 (comment). In context, I think this way of describing things when Constant Size is off does feel really natural:
Now that I hear everything together, I take back my previous comment. I don't think referring to the density is adding any complexity here. However, I am still uneasy with the help text that reads: There's a value-unit mismatch here. You proposed some good alternatives in #149 (comment), and I think option (4) is probably the way to go.
I think referring to density in the help text better differentiates between the Constant Size modes and has a nice parallel to the descriptions/alerts associated with changing the mass. I don't think it's particularly important to be precise with the density units, so I would use the more generalized "per unit volume" for GFL and GFLB. |
@arouinfar, thanks for your review and feedback. I'll make the changes clear in the design doc and assign them over to @zepumph in the morning! |
@zepumph, in the end of this discussion we have one small string that needs to be added to the help text for the mass controls when the Constant Size checkbox is checked. There isno change to the help text when the Constant Size checkbox is not checked. The New Additional String:Please add the bolded string to the end of the help text when the Constant Size check box is checked.
Adding that Design Document has been updated (see https://docs.google.com/document/d/1HdDG9ds2MdbCb21l9qk3cI8yBQxK6-wBWNXC4Tloji8/edit#heading=h.psnu7qusgz2n). |
Sounds good. Anything else for this issue? |
@zepumph, I went to the commit, it looks like the change has been made in Gravity Force Lab regular, but I don't see it yet in Gravity Force Lab Basics where we have "billions" of kilograms. It will good to have both sims do the same thing, i.e., add {{per unit volume}} at the end of the help text that contains "density", but in BASICS we need additionally "billions of kilograms". |
Sorry I didn't check my work thoroughly. I noticed while making this new change that these BASICS strings were in the REGULAR strings file. I moved them to GFLB for clarity. Back to you for a sanity check. |
Thanks! All looking good now when Constant Size is checked! |
Based on comments from @arouinfar's #142 (comment), we may need to adjust how we are describing density in help text and alerts.
Note @arouinfar, I said that you did not experience the latest version of the sim's descriptions, but in fact you may have. Did you use this link from the Dev Test issue:
https://phet-dev.colorado.edu/html/gravity-force-lab-basics/1.0.0-dev.39/phet/gravity-force-lab-basics_all_phet.html
Now quoting from your comment #142 (comment)
There are 2 parts to this issue regarding descriptions when the Constant Size checkbox is checked:
The text was updated successfully, but these errors were encountered: