Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove list structure on Mass Controls #138

Closed
terracoda opened this issue May 31, 2019 · 2 comments
Closed

Remove list structure on Mass Controls #138

terracoda opened this issue May 31, 2019 · 2 comments

Comments

@terracoda
Copy link

In light of phetsims/ohms-law#148 (comment), it is likely best to remove the list structure around the Mass controls.

Hopefully, this is quite easy to do.
@zepumph, I'd keep the aria-labelledby on the parent div.

Possible pseudo-code

<h3 id="mass-heading">Mass Controls</h3>
<div aria-labelledby="mass-heading">
<Mass 1 slider/number spinner>
<Mass 2 slider/number spinner>
</div>
@zepumph
Copy link
Member

zepumph commented May 31, 2019

I ended up replacing the UL with a div, and the LI with a div. The resulting output has more divs, but keeps the aria-valuetext in the a11y view more inline:

image

When the LI tags are just removed, we get this:

image

I can do either one, but just committed the one with an extra nested 'div' please review.

@terracoda
Copy link
Author

@zepumph, the goup of mass controls sounds great on VoiceOver! Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants