Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other mass name to "go-beyond-edge" alerts #137

Closed
terracoda opened this issue May 24, 2019 · 3 comments
Closed

Add other mass name to "go-beyond-edge" alerts #137

terracoda opened this issue May 24, 2019 · 3 comments

Comments

@terracoda
Copy link

terracoda commented May 24, 2019

In following up to issue #135, if there is time please add the other mass's name, so these "go-beyond-edge" alerts so they would look like this:

Random examples for mass 1:

  • Farthest from mass 2, force arrows tiny, forces 0.7 ‪newtons‬.
  • Closest to mass 2, force arrows tiny, forces 39.5 ‪newtons‬.
  • Extremely close to mass 2, force arrows very small, forces 144.2 ‪newtons‬.
  • Very close to mass 2, force arrows huge, forces 1067.9 ‪newtons‬.

Random examples for mass 2:

  • Extremely close to mass 1, force arrows small, forces 184.7 ‪newtons‬.
  • Far from mass 1, force arrows tiny, forces 11.5 ‪newtons‬.
  • Very close to mass 1, force arrows large, forces 454 ‪newtons‬.
  • Farthest from mass 1, force arrows tiny, forces 21.7 ‪newtons‬.

As mentioned in #135 (comment), I don't want this request to block this sim from going into Dev Testing.

If logic to handle this request does not already exist, we could make this addition when we are finishing off GFL Regular. I am marking as low priority (so as not be a blocking issue).

@zepumph
Copy link
Member

zepumph commented Jun 17, 2019

Implementing this simplified some of the code, so it was nice to do as part of the code review in #134. @terracoda please review.

@terracoda
Copy link
Author

Awesome, I'll verify in the morning ;-)

@terracoda
Copy link
Author

Adding the mass name to these edge alerts sounds awesome to me! Thanks for adding this nice polish to the alerts. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants