Keyboard Shortcuts Dialog adjustments & additions

[terracoda]

There are no small steps in this sim, but there are in GFL Regular. If it is possible and not too tedious due to shared resources between the 2 sims (3 if you include Coulomb's Law):

• Please remove the line about small steps under Change Mass (but only if this is not a big pain)

Also, this sim and GFL Regular have checkboxes, so

• Under Basic Actions, please add the instructions for checkboxes after the item already there for buttons
  • The visual representation would be just like the button item, but with different words. The square brackets represent the Space key icon.:
    • "Toggle checkboxes [SPACE]"
  • The a11y text for the checkbox item is:
    • "Toggle checkboxes with Space key."

Edited: added only if line.

[terracoda]

@zepumph, do you need a visual for this?

[zepumph]

No visual needed, implemented both of them (as it was simple in the way it was set up). Let me know what you think

[terracoda]

@zepumph, sounds and looks great, but could you please put the "Toggle checkboxes" line just after the Press buttons and just before the Escape to exit dialog.

Apologies for not being explicit about the order in the original post.

[zepumph]

In the above commit I reordered things, and I also refactored GeneralKeyboardHelpSection to be more explicit and easy to tell what the final order is. I also converted to es6. @terracoda please review, and also note that all the work done for this is in common code, and that this is now an option anywhere (I think you already knew that).

[terracoda]

@zepumph, the content looks and sounds great.

I think there might be an extra aria-labelledby because I am hearing an end of group announcement after the starting heading block of the dialog.

I have heard this before, and I just looked in the code to see why...

I don't think we need the second aria-labelledby attribute. Where should I start an issue for a common code issue for a little tweaking of the dialog? Which repo does this common code item belong to?

[terracoda]

Oh duh, I see the commit was in scenery-phet. I'll move the comment to scenery-phet.

[terracoda]

@zepumph, please close this issue when phetsims/scenery-phet#494 is addressed.

[terracoda]

@zepumph, I will close this issue as it is common to all sims and any needed work will be done in phetsims/scenery-phet#494