-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position slider's verbose aria-valuetext: describe position instead of providing a kilometer mark #107
Comments
@emily-phet, do you see what I am trying to do with these descriptions?
|
Feedback from March 12th Design Meeting:
|
@terracoda to update design document examples and walkthrough with new phrases for position and distance.
Note that having different (more versbose) |
@zepumph, I removed "describe center explicitly" from title as we decided not to consider doing that. |
I have a couple options for the phrasing to discuss at Tuesday's GFLB design meeting, so marking as a meeting issue one last time before implementation. |
@zepumph, I've got all position/distance changes updated in the design document and will be assigning things over to you after Tuesday's design meeting when I clarify the wording on a couple of phrases. |
@zepumph, the changes for position/distance are summarized in section Summary of position/distance The Table: Position Regions & Landmarks outlines the strings that replace all the kilometer-mark positions. These are the biggest changes. The examples demonstrated in the tables for focus events and the big cognitive walkthrough have all been updated. Changes are noted in red. And I left the current implementations there, but crossed out. Notes in the last column describe what is verified and working (green highlights) and where there are issues (red highlights) or red comments. I hope this all makes sense. If not, we can discuss late Tuesday/early Wednesday, I am now on Daylight Savings time, too. |
Marking as high priority in case it is possible to get these changes in for interviews in the later half of next week. |
@zepumph, #107 (comment) is basically contains three tasks that all intermingled: Task 1: Replace all strings that contain kilometer marks (position value) with one of the new described position regions or landmarks. All together there are about 6 described position values which are laid out the Table: Position Regions & Landmarks:
Task 2: Adjust
Task 3: Use the Cognitive walk-through as a guide to update I hope that makes things more clear. I can make 3 issues if yo would prefer. Apologies for the mega-issue. |
@terracoda hopefully a lot/most of this is accomplished. Like you predicted, I was able to simplify quite a bit of logic in PositionDescriber, because the "edge cases" are built into the main value text generating function. I don't think this is without quirks and bugs, but I walked through the walkthrough, only looking at the white rows (with distance checked), and things are looking pretty nice! I'm excited to talk tonight. |
@zepumph, we have some issues with the grey rows. Task 1: Is working perfectly. I do not hear kilometer marks, and instead get descriptions of my place along the track. I get correct Task 2: The Task 3 (with Distance checked): Yes, the white rows, which represent what should be heard when Distance is checked, work perfectly! I hear the progress indicators with distance in kilometers on first step and on directional changes. I hear distance in kilometers on subsequent steps in the same direction. I hear the position landmarks and distance in kilometers at min and max positions (track ends, and last stops). Task 3 (with Distance not checked): The grey rows, however, where we are to get described regions for position rather than actual distance in kilometers are working a bit erratically. In fact, I think Voice Over is reading out the @zepumph, I am going to close this issue - as all 3 tasks were implemented - and start a new one to focus on the issues in Task 3 (Distance not checked). Since the |
Oops did not mean to post - will edit previous comment. |
@zepumph, I significantly updated #107 (comment). |
And will start a new issue for Task 3 (with Distance not checked). |
With some indication from interviews...Providing both the kilometer mark and distance from other sphere on focus of a mass position slider may not be super helpful.
The values together seem to be a bit of information/number overload, and it is not clear to @terracoda if the kilometer mark value is of much importance to the the learning goals of the simulation. Initial thinking was that the kilometer mark could provide some orientation of where the sphere is positioned along the invisible track of the slider.
Questions:
aria-valuetext
provided on focus.Note that a dynamic verbose value for
aria-valuetext
is dependent on phetsims/scenery#951Note that examples do not include the brief focus alert describing the size of the force arrows.
Currently, verbose
aria-valuetext
provides:With Distance checked kilometer mark and distance in kilometers:
With Distance NOT checked kilometer mark and described relative distance:
Initial idea for a change to the verbose
aria-valuetext
Option 1: Remove positioning along track all together and add "center" somewhere
With Distance checked, distance in kilometers:
With Distance NOT checked, described relative distance:
Option 2: If position is needed, describe position on track instead
With Distance checked, distance in kilometers:
With Distance NOT checked, described relative distance:
If described position in Option 2 is needed, possible descriptions for track position could be:
We already have 3 position landmarks implemented:
Edited: Change number of interviews.
The text was updated successfully, but these errors were encountered: