Skip to content

Commit

Permalink
self-voicing -> voicing in many comments, see phetsims/tasks#1083
Browse files Browse the repository at this point in the history
  • Loading branch information
jessegreenberg committed Mar 25, 2021
1 parent 241b752 commit b0d92cf
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
6 changes: 3 additions & 3 deletions js/view/GFLBAlertManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class GFLBAlertManager extends GravityForceLabAlertManager {
}

/**
* Get a string for the self voicing prototype that describes the changing visibility of force values.
* Get a string for the voicing prototype that describes the changing visibility of force values.
* @private
* @param {boolean} showForceValues
* @returns {string}
Expand All @@ -97,7 +97,7 @@ class GFLBAlertManager extends GravityForceLabAlertManager {
}

/**
* Get a string for the self voicing prototype that describes the changing visibility of distance.
* Get a string for the voicing prototype that describes the changing visibility of distance.
* @private
* @param {boolean} showDistance
* @returns {string}
Expand All @@ -107,7 +107,7 @@ class GFLBAlertManager extends GravityForceLabAlertManager {
}

/**
* Get a string for the self voicing prototype that describes the changing visibility of distance.
* Get a string for the voicing prototype that describes the changing visibility of distance.
* @private
* @param {boolean} constantRadius
* @returns {string}
Expand Down
2 changes: 1 addition & 1 deletion js/view/GFLBCheckboxPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class GFLBCheckboxPanel extends ISLCPanel {
const checkboxGroup = new VerticalCheckboxGroup( checkboxItems, options.checkboxGroupOptions );
super( checkboxGroup, options );

// PROTOTYPE a11y code, for the self-voicing feature set
// PROTOTYPE a11y code, for the voicing feature set
if ( phet.chipper.queryParameters.supportsVoicing ) {

// list of interaction hints to be read upon focus, in the order of checkboxes. Pretty rough, but better
Expand Down
4 changes: 2 additions & 2 deletions js/view/GFLBMassControl.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class GFLBMassControl extends Panel {
options = merge( {
color: new Color( 0, 0, 255 ),

// {null|string} (self-voicing) custom content to guide the user to dragging with custom gesture
// {null|string} (voicing) custom content to guide the user to dragging with custom gesture
changeMassHintString: null
}, options );

Expand Down Expand Up @@ -141,7 +141,7 @@ class GFLBMassControl extends Panel {
tagName: 'div' // Though not necessary, it is helpful for the a11y view to display the valuetext within this div.
} );

// PROTOTYPE a11y code, for the self-voicing feature set
// PROTOTYPE a11y code, for the voicing feature set
if ( phet.chipper.queryParameters.supportsVoicing ) {

// create a hit shape that will capture events on the panel and also exclude hits on the picker when
Expand Down
4 changes: 2 additions & 2 deletions js/view/GFLBMassNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class GFLBMassNode extends MassNode {
// pdom recompute the PDOM descriptions when show distance is toggled
additionalA11yDependencies: [ model.showDistanceProperty ],

// self-voicing
// voicing
grabHintLabel: null
}, options );

Expand Down Expand Up @@ -104,7 +104,7 @@ class GFLBMassNode extends MassNode {
}

/**
* Part of the self-voicing prototype. User has ended a drag of the appendage.
* Part of the voicing prototype. User has ended a drag of the appendage.
* @public (called by SwipeListener)
*
* @param {SceneryEvent} event
Expand Down
8 changes: 4 additions & 4 deletions js/view/GFLBScreenView.js
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ class GFLBScreenView extends ScreenView {
}

//------------------------------------------------
// self-voicing prototype
// voicing prototype
//------------------------------------------------
if ( phet.chipper.queryParameters.supportsVoicing ) {

Expand All @@ -403,7 +403,7 @@ class GFLBScreenView extends ScreenView {

// extra controls to speak about various things in the sim or quickly disable
// the feature
const selfVoicingQuickControl = new VoicingQuickControl( webSpeaker, {
const voicingQuickControl = new VoicingQuickControl( webSpeaker, {
createHintContent: () => {
return StringUtils.fillIn(
summaryInteractionHintPatternString,
Expand Down Expand Up @@ -447,7 +447,7 @@ class GFLBScreenView extends ScreenView {
},
leftBottom: this.layoutBounds.leftBottom.minusXY( -8, 8 )
} );
this.addChild( selfVoicingQuickControl );
this.addChild( voicingQuickControl );

resetAllButton.addInputListener( new VoicingInputListener( {
onFocusIn: () => {
Expand All @@ -464,7 +464,7 @@ class GFLBScreenView extends ScreenView {

// in this mode, focus just goes from top to bottom, but starting with the quick control
// to guide the user to hear details about the simulation first
massPositionsNode.pdomOrder = [ selfVoicingQuickControl, mass2Node.voicingWrapper, mass1Node.voicingWrapper, distanceArrowNode.voicingWrapper, null ];
massPositionsNode.pdomOrder = [ voicingQuickControl, mass2Node.voicingWrapper, mass1Node.voicingWrapper, distanceArrowNode.voicingWrapper, null ];
}

if ( phet.chipper.queryParameters.vibrationParadigm ) {
Expand Down

0 comments on commit b0d92cf

Please sign in to comment.