refactoring GravityForceLabAlertManager, and remove unused parameters…

…/vars etc, update visibility annotations, #134
phetsims · Jun 18, 2019 · a1b1dba · a1b1dba
1 parent a5c93d9
commit a1b1dba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/js/gravity-force-lab-basics/view/GFLBAlertManager.js b/js/gravity-force-lab-basics/view/GFLBAlertManager.js
@@ -20,10 +20,9 @@ define( require => {
      * @param {GFLBModel} model
      * @param {GFLBMassDescriber} massDescriber
      * @param {GFLBForceDescriber} forceDescriber
-     * @param {GFLBPositionDescriber} positionDescriber
      */
-    constructor( model, massDescriber, forceDescriber, positionDescriber ) {
-      super( model, massDescriber, forceDescriber, positionDescriber, {
+    constructor( model, massDescriber, forceDescriber ) {
+      super( model, massDescriber, forceDescriber, {
         linkToScientificNotationProperty: false, // opt out of REGULAR specific linking
 
         // by default the REGULAR version is different from this because of scientific notation

diff --git a/js/gravity-force-lab-basics/view/GFLBScreenView.js b/js/gravity-force-lab-basics/view/GFLBScreenView.js
@@ -90,7 +90,7 @@ define( require => {
       const positionDescriber = new GFLBPositionDescriber( model, mass1LabelString, mass2LabelString );
       const forceDescriber = new GFLBForceDescriber( model, mass1LabelString, mass2LabelString, positionDescriber );
       const massDescriber = new GFLBMassDescriber( model );
-      const alertManager = new GFLBAlertManager( model, massDescriber, forceDescriber, positionDescriber );
+      const alertManager = new GFLBAlertManager( model, massDescriber, forceDescriber );
 
       // The PDOM screen summary
       const summaryNode = new GravityForceLabScreenSummaryNode( model, massDescriber, forceDescriber, positionDescriber, {