Skip to content

Commit

Permalink
added asset for mass sound, re-encoded MP3 file to have complete fade…
Browse files Browse the repository at this point in the history
… out, modified play options, see #166
  • Loading branch information
jbphet committed Jul 30, 2019
1 parent 05cbecb commit 553b17c
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 2 deletions.
Binary file added assets/rubber-band-v3.wav
Binary file not shown.
5 changes: 4 additions & 1 deletion js/gravity-force-lab-basics/view/MassSoundGenerator.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ define( require => {
const GFLBConstants = require( 'GRAVITY_FORCE_LAB_BASICS/gravity-force-lab-basics/GFLBConstants' );

// sounds
const massSound = require( 'sound!GRAVITY_FORCE_LAB_BASICS/rubber-band-v2-middle-c.mp3' );
const massSound = require( 'sound!GRAVITY_FORCE_LAB_BASICS/rubber-band-v3.mp3' );

// constants
const PITCH_RANGE_IN_SEMI_TONES = 30;
Expand All @@ -29,6 +29,9 @@ define( require => {
*/
constructor( massProperty, resetInProgressProperty, options ) {

// Rate changes should never affect the mass sound that is already playing.
options.rateChangesAffectPlayingSounds = false;

super( massSound, options );

// function for playing the mass sound
Expand Down
2 changes: 1 addition & 1 deletion sounds/license.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rubber-band-v2-middle-c.mp3": {
"rubber-band-v3.mp3": {
"text": [
"Copyright 2002-2019 University of Colorado Boulder"
],
Expand Down
Binary file removed sounds/rubber-band-v2-middle-c.mp3
Binary file not shown.
Binary file added sounds/rubber-band-v3.mp3
Binary file not shown.

0 comments on commit 553b17c

Please sign in to comment.