Skip to content

Commit

Permalink
rename distanceProperty -> separationProperty, phetsims/gravity-force…
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Aug 22, 2019
1 parent 935c4dc commit 11264d1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion js/gravity-force-lab-basics/view/DistanceArrowNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ define( require => {

// update label text and center, distance in meters so divide by 1000 to read out in km
labelText.setText( StringUtils.fillIn( distanceUnitsPatternString, {
distance: model.distanceProperty.get() / 1000 // m to km
distance: model.separationProperty.get() / 1000 // m to km
} ) );

labelText.centerX = arrowNode.centerX;
Expand Down
4 changes: 2 additions & 2 deletions js/gravity-force-lab-basics/view/GFLBScreenView.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ define( require => {

Property.multilink( [

// Linking to `model.distanceProperty` (back when the distanceProperty was in GFLBModel) caused the same bug as in GFLB#103, so we are linking to
// Linking to `model.separationProperty` caused the same bug as in GFLB#103, so we are linking to
// both objects' positionProperty instead.
model.object1.positionProperty,
model.object2.positionProperty,
Expand Down Expand Up @@ -240,7 +240,7 @@ define( require => {
// sound generation for masses (almost) colliding with one another
const innerBoundarySoundClip = new SoundClip( innerBoundarySound, { initialOutputLevel: 0.5 } );
soundManager.addSoundGenerator( innerBoundarySoundClip );
model.distanceProperty.lazyLink( ( distance, previousDistance ) => {
model.separationProperty.lazyLink( ( distance, previousDistance ) => {
if ( distance < previousDistance ) {

// the distance value from the ISLC model is rounded to 100s of meters, so we do the same thing here
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ window.phet.phetio.phetioElementsBaseline = assert &&
"phetioStudioControl": true,
"phetioTypeName": "PropertyIO.<BooleanIO>"
},
"gravityForceLabBasics.gravityForceLabBasicsScreen.model.distanceProperty": {
"gravityForceLabBasics.gravityForceLabBasicsScreen.model.separationProperty": {
"phetioDocumentation": "The distance between the two objects' centers",
"phetioDynamicElement": false,
"phetioEventType": "MODEL",
Expand Down

0 comments on commit 11264d1

Please sign in to comment.