Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No audio tab to hide #465

Closed
Tracked by #850
KatieWoe opened this issue Oct 6, 2022 · 3 comments
Closed
Tracked by #850

No audio tab to hide #465

KatieWoe opened this issue Oct 6, 2022 · 3 comments
Labels
status:ready-for-review type:bug

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Oct 6, 2022

Test device
MacBook Pro
Operating System
MacOS 12.6
Browser
Chrome
Problem description
For phetsims/qa#841
The guide contains this element: gravityAndOrbits.general.view.navigationBar.preferencesButton.preferencesDialogCapsule.preferencesDialog.preferencesTabs.audioTab.visibleProperty but no such element is in the tree as there is no sound.
samreid added a commit to phetsims/qa that referenced this issue Oct 11, 2022
@samreid
Update documentation regarding PreferencesDialog, see phetsims/gravit…
720ec62 
…y-and-orbits#465
samreid added a commit to phetsims/joist that referenced this issue Oct 11, 2022
@samreid
Update documentation regarding PreferencesDialog, see phetsims/gravit…
6956eae 
…y-and-orbits#465
@samreid
Copy link
Member

samreid commented Oct 11, 2022

@zepumph and I fixed the documentation above, for cherry-picking we only need phet-io-sim-specific.
https://github.com/phetsims/phet-io-sim-specific/commit/59fb542016aded667261c8958912bfed8e5de81e

This was referenced Oct 21, 2022
Closed
Closed
@samreid samreid mentioned this issue Nov 9, 2022
Closed
5 tasks
@samreid
Copy link
Member

samreid commented Nov 9, 2022

Please close after verifying.

@KatieWoe
Copy link
Contributor Author

The changes in the linked commit are present. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-for-review type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @arouinfar @KatieWoe