Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design of Restart button doesn't match other buttons #447

Closed
Tracked by #841
Nancy-Salpepi opened this issue Sep 28, 2022 · 6 comments
Closed
Tracked by #841

Design of Restart button doesn't match other buttons #447

Nancy-Salpepi opened this issue Sep 28, 2022 · 6 comments

Comments

@Nancy-Salpepi
Copy link

For phetsims/qa#838
The restart button has a light gray outline around each component that isn't present in the other buttons. This inconsistency is also in the published version.

Screen Shot 2022-09-27 at 5 26 00 PM

@arouinfar
Copy link
Contributor

arouinfar commented Sep 29, 2022

Thanks @Nancy-Salpepi.

@samreid can you remove the stroke around the icon on the restart button? If not, let's at least make the stroke black so the icon looks more consistent with the other buttons.

@arouinfar arouinfar assigned samreid and unassigned arouinfar Sep 29, 2022
@samreid
Copy link
Member

samreid commented Oct 4, 2022

This common code component is also used in Wave on a String, Collision Lab and My Solar System. Should it be changed for all occurrences? If not, what should the default be?

@samreid samreid assigned arouinfar and unassigned samreid Oct 4, 2022
@arouinfar
Copy link
Contributor

@samreid the stroke appearance should match the icons on the PlayPauseButton and StepForwardButton. The change can apply universally to all sims.

@arouinfar arouinfar assigned samreid and unassigned arouinfar Oct 4, 2022
@zepumph
Copy link
Member

zepumph commented Oct 4, 2022

@samreid and I reworked the design, removing the grey stroke and updating the icon to look more like the other play/pause icons.

My solar system:
image

Gravity and orbits:
image

We also glanced at https://fontawesome.com/icons/backward-fast?s=solid&f=sharp for inspiration.

Anything else here @arouinfar?

zepumph added a commit to phetsims/scenery-phet that referenced this issue Oct 4, 2022
@zepumph zepumph assigned arouinfar and unassigned samreid Oct 4, 2022
@arouinfar
Copy link
Contributor

Looks great, thanks @zepumph @samreid.

@Nancy-Salpepi
Copy link
Author

Looks perfect in master and in 1.6.0-rc.3. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants