Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity and Velocity Arrows missing in Screenshot #426

Closed
Nancy-Salpepi opened this issue Jun 30, 2022 · 5 comments
Closed

Gravity and Velocity Arrows missing in Screenshot #426

Nancy-Salpepi opened this issue Jun 30, 2022 · 5 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
macOS 12.4

Browser
Safari and chrome

Problem description
For phetsims/qa#816

When I take a screenshot in the Screenshot Wrapper, the velocity and gravity arrows are missing. Also seen in master, but nothing came up in the console.

**I tried version 1.5 and the screenshot was correct.

Steps to reproduce

  1. Go to either screen in the Screenshot Wrapper
  2. Check Gravity Force and Velocity checkboxes
  3. Press Take Screenshot button

Visuals
Screen Shot 2022-06-30 at 5 03 23 PM

@zepumph
Copy link
Member

zepumph commented Jun 30, 2022

Seems like a sim-specific issue

@Nancy-Salpepi
Copy link
Author

I am also seeing this when I take a screenshot from the PhET menu in the standalone sim and the PhET brand sim.

@Nancy-Salpepi
Copy link
Author

This issue is also seen with iOS 15.5 using both the screenshot wrapper and the screenshot tool in the PhET menu.

@samreid
Copy link
Member

samreid commented Jul 13, 2022

Good catch, it's fixed in the commit and ready for review in the upcoming RC. We will also need to check that the fix doesn't negatively impact performance.

@samreid samreid removed their assignment Jul 13, 2022
@samreid
Copy link
Member

samreid commented Sep 3, 2022

No performance problem were reported in the preceding dev tests. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants