Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT Designed API changes detected #409

Closed
KatieWoe opened this issue Sep 20, 2021 · 3 comments
Closed

CT Designed API changes detected #409

KatieWoe opened this issue Sep 20, 2021 · 3 comments

Comments

@KatieWoe
Copy link
Contributor

gravity-and-orbits : phet-io-api-compatibility : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1632138742661/gravity-and-orbits/gravity-and-orbits_en.html?continuousTest=%7B%22test%22%3A%5B%22gravity-and-orbits%22%2C%22phet-io-api-compatibility%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1632138742661%22%2C%22timestamp%22%3A1632147132952%7D&ea&brand=phet-io&phetioStandalone&phetioCompareAPI&randomSeed=332211
Query: ea&brand=phet-io&phetioStandalone&phetioCompareAPI&randomSeed=332211
Uncaught Error: Assertion failed: Designed API changes detected, please roll them back or revise the reference API:

New PhET-iO Element not in reference: gravityAndOrbits.general.view.audioManager
Error: Assertion failed: Designed API changes detected, please roll them back or revise the reference API:

New PhET-iO Element not in reference: gravityAndOrbits.general.view.audioManager
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1632138742661/assert/js/assert.js:25:13)
at XMLHttpRequest.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1632138742661/chipper/dist/phet-io/js/phetioEngine.js:266:35)
id: Bayes Chrome
Snapshot from 9/20/2021, 5:52:22 AM
@samreid
Copy link
Member

samreid commented Sep 21, 2021

This was introduced in phetsims/joist#745, @zepumph should we regenerate the API?

@samreid samreid assigned zepumph and unassigned samreid Sep 21, 2021
@zepumph
Copy link
Member

zepumph commented Sep 21, 2021

Thanks @KatieWoe, @samreid and I realized that this is because I didn't compile GAO before running grunt generate-phet-io-api. This will be a step that is always needed to regenerate the API for a sim that uses TS.

@zepumph zepumph assigned samreid and unassigned zepumph Sep 21, 2021
samreid added a commit to phetsims/chipper that referenced this issue Oct 2, 2021
@samreid
Copy link
Member

samreid commented Oct 2, 2021

I added this to the TypeScript Quick Start guide, maybe one day we will have better tooling for this, but at least it's documented for now. Closing.

@samreid samreid closed this as completed Oct 2, 2021
samreid added a commit to phetsims/phet-info that referenced this issue Oct 26, 2021
samreid added a commit to phetsims/phet-info that referenced this issue Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants