Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroyed objects "explode" in launched sim #344

Closed
KatieWoe opened this issue Jun 4, 2020 · 3 comments
Closed

Destroyed objects "explode" in launched sim #344

KatieWoe opened this issue Jun 4, 2020 · 3 comments

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Jun 4, 2020

Device
Dell
OS
Win 10
Browser
Chrome
Problem Description
For phetsims/qa#505.
When in studio, if you make objects crash together and destroy each other, then launch the sim, you will see the "explosion" animation even though the object should just be gone. This happens when you would first view the changed scene, even if you have to navigate to it after the sim is launched.
Steps

  1. Go the first screen
  2. Drag the planet into the star
  3. Go to the second scene in the first screen
  4. Drag that planet into the star
  5. Go back to the first scene
  6. Launch the sim and observe both scenes

Visual
shouldexplode

@samreid
Copy link
Member

samreid commented Jun 8, 2020

@arouinfar and I agreed this would be nice to fix in the next dev version, since it seems like it could impact a customized version. However, it is unlikely that the client would want to create a customized sim that has a pre-exploded object. So if it is difficult to solve, it could wait for RC.

@samreid
Copy link
Member

samreid commented Jun 16, 2020

I pushed a proposed fix, @KatieWoe can you please test in master?

@KatieWoe
Copy link
Contributor Author

Looks fixed in master

@KatieWoe KatieWoe assigned samreid and unassigned KatieWoe Jun 17, 2020
@samreid samreid closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants