Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State Wrapper May Not Show Path #335

Closed
KatieWoe opened this issue Jun 1, 2020 · 7 comments
Closed

State Wrapper May Not Show Path #335

KatieWoe opened this issue Jun 1, 2020 · 7 comments
Assignees
@samreid @KatieWoe
Labels
status:ready-for-review type:bug

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Jun 1, 2020

For phetsims/qa#505
On my Win 10 laptop on both Chrome 83.0.4103.61 and Firefox 76.0.1. I did not see the orbit path on the bottom state sim in phet-io. @loganbraywork has a Win 10 device and does see the path, and is making a separate issue for something he saw there. This makes me think it is something about my computer that caused this, but I'm unsure what. @samreid let me know what info about my device might help and I'll send it to you.
notseeingpath
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Jun 1, 2020

It may be specific Win 10 versions? I'm on v1909 and @loganbraywork just told me he is on v1903

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Jun 3, 2020

I am seeing this on Mac 10.15.5 Safari as well.

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Jun 4, 2020

Path disappears from launched sim in studio as well.
launchedpathgoesaway

@samreid
Copy link
Member

samreid commented Jun 8, 2020

In discussion with @arouinfar, we agreed: Since a client may want to create an initial condition with a pre-existing path, this should be addressed before next dev version.

samreid added a commit that referenced this issue Jun 10, 2020
@samreid
Added path to the state, see #335
1c920f7
@samreid
Copy link
Member

samreid commented Jun 10, 2020

I added path to the state in the commit. @KatieWoe can you please review on phettest?

@samreid samreid assigned KatieWoe and unassigned samreid Jun 10, 2020
@KatieWoe
Copy link
Contributor Author

Looks like it is showing up on Win 10 Chrome now

@samreid
Copy link
Member

samreid commented Jun 10, 2020

Excellent, thanks, closing.

@samreid samreid closed this as completed Jun 10, 2020
@samreid samreid mentioned this issue Jun 11, 2020
Closed
@Nancy-Salpepi Nancy-Salpepi mentioned this issue Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

@KatieWoe KatieWoe

Labels
status:ready-for-review type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @KatieWoe