Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve centering of the grid and bodies #327

Closed
samreid opened this issue May 19, 2020 · 3 comments
Closed

Improve centering of the grid and bodies #327

samreid opened this issue May 19, 2020 · 3 comments
Assignees
@arouinfar
Labels
priority:2-high

Comments

@samreid
Copy link
Member

samreid commented May 19, 2020

While working on #302 @arouinfar and I noticed the bodies sometimes get too close to the play/pause button:

image

image

We recommend to remedy this by moving the entire grid up around 1/4 of a cell.
@samreid samreid self-assigned this May 19, 2020
@samreid
Copy link
Member Author

samreid commented May 19, 2020

Moving the view up by 50px looks like this:

image

samreid added a commit that referenced this issue May 19, 2020
@samreid
Translate view up by 50px, see #327
96d4d8c
@samreid
Copy link
Member Author

samreid commented May 19, 2020

I tested across a few scenes and it seemed reasonable, so I committed the 50px translation. @arouinfar can you please take a closer look?

@samreid samreid assigned arouinfar and unassigned samreid May 19, 2020
@arouinfar
Copy link
Contributor

@samreid looks good in master.

@arouinfar arouinfar mentioned this issue Jun 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
priority:2-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @arouinfar