We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related to code review #173.
In ModeListParameterList:
/** * * @param {Property<boolean>} playButtonPressed * @param {Property<boolean>} gravityEnabled * @param {Property<boolean>} stepping * @param {Property<boolean>} rewinding * @param {Property<number>} timeSpeedScale * @constructor */ function ModeListParameterList( playButtonPressed, gravityEnabled, stepping, rewinding, timeSpeedScale )
Per PhET naming conventions, all of these parameters must be renamed to have a Property suffix. Eg:
Property
playButtonPressed -> playButtonPressedProperty
The text was updated successfully, but these errors were encountered:
Same problem in GravityAndOrbitsClock, CartoonModeList and RealModeList.
Sorry, something went wrong.
rename properties with Property suffix, see #196
dec7b28
I've made these changes, assigning to @pixelzoom for review.
Spot checked, looks good, closing.
pixelzoom
No branches or pull requests
Related to code review #173.
In ModeListParameterList:
Per PhET naming conventions, all of these parameters must be renamed to have a
Property
suffix. Eg:playButtonPressed -> playButtonPressedProperty
The text was updated successfully, but these errors were encountered: