Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var names of type {Property} must have a 'Property' suffix #196

Closed
pixelzoom opened this issue Nov 9, 2015 · 3 comments
Closed

var names of type {Property} must have a 'Property' suffix #196

pixelzoom opened this issue Nov 9, 2015 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

Related to code review #173.

In ModeListParameterList:

/**
   *
   * @param {Property<boolean>} playButtonPressed
   * @param {Property<boolean>} gravityEnabled
   * @param {Property<boolean>} stepping
   * @param {Property<boolean>} rewinding
   * @param {Property<number>} timeSpeedScale
   * @constructor
   */
function ModeListParameterList( playButtonPressed, gravityEnabled, stepping, rewinding, timeSpeedScale ) 

Per PhET naming conventions, all of these parameters must be renamed to have a Property suffix. Eg:

playButtonPressed -> playButtonPressedProperty

@pixelzoom
Copy link
Contributor Author

Same problem in GravityAndOrbitsClock, CartoonModeList and RealModeList.

@aaronsamuel137
Copy link
Contributor

I've made these changes, assigning to @pixelzoom for review.

@pixelzoom
Copy link
Contributor Author

Spot checked, looks good, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants