issues with Properties for measuring tape visibility

[pixelzoom]

Related to code review #173.

Here's the code in question:

 function GravityAndOrbitsModule( showMeasuringTape, createModes, initialModeIndex, showMassCheckBox ) {

    // Properties that are common to all "modes" should live here.
    PropertySet.call( this, {
      ...
      measuringTapeVisible: false,
      ...
      showMeasuringTape: false
    } );

    ...

    this.showMeasuringTape = showMeasuringTape;

(1) Why are there 2 properties related to visibility of the measuring tape? (measuringTapeVisible, showMeasuringTape)

(2) Why is the function argument not used to set the initial value of showMeasuringTape or measuringTapeVisible?

[aaronsamuel137]

Good catch. showMeasuringTape is supposed to be a boolean and not a property. I have corrected and documented. Assigning to @pixelzoom for review.

[pixelzoom]

👍 Closing.