Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad type expressions in JSdoc #184

Closed
pixelzoom opened this issue Nov 9, 2015 · 3 comments
Closed

bad type expressions in JSdoc #184

pixelzoom opened this issue Nov 9, 2015 · 3 comments
Assignees
@pixelzoom
Labels
dev:code-review

Comments

@pixelzoom
Copy link
Contributor

For example in Body.js:

@param {Property<boolean>} playButtonPressedProperty

should be

@param {Property.<boolean>} playButtonPressedProperty

Note the '.' before ''.

This occurs throughout the code.
@pixelzoom
Copy link
Contributor Author

Related to code review #173.

aaronsamuel137 added a commit that referenced this issue Nov 11, 2015
@aaronsamuel137
fix type expression, see #184
39655b3
@aaronsamuel137
Copy link
Contributor

Should be fixed. Assigning to @pixelzoom for review.

@pixelzoom
Copy link
Contributor Author

Spot checked, looks great. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @aaronsamuel137 @ariel-phet