Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing asset file for cartoon_icon.png #178

Closed
pixelzoom opened this issue Nov 9, 2015 · 5 comments
Closed

missing asset file for cartoon_icon.png #178

pixelzoom opened this issue Nov 9, 2015 · 5 comments
Labels
dev:code-review

Comments

@pixelzoom
Copy link
Contributor

Related to code review #173.

This entry in images/license.json has no associated .ai file in assets/.

  "cartoon_icon.png": {
    "text": [
      "Copyright 2002-2015 University of Colorado Boulder"
    ],
    "projectURL": "http://phet.colorado.edu",
    "license": "contact [email protected]",
    "notes": "created by Bryce Gruneich and Sharon Siman-Tov"
  },
@aaronsamuel137
Copy link
Contributor

It's included in the to_scale_icon.ai file. Would you recommend splitting these into 2 files or just renaming to something like screen_icons.ai?

@pixelzoom
Copy link
Contributor Author

Since there is a 1:1 mapping from png:ai for all other files, I'd recommend splitting this out. Otherwise I'd never know which file to look in, and I'd assume that it's missing.

@pixelzoom pixelzoom assigned aaronsamuel137 and unassigned pixelzoom Nov 9, 2015
@pixelzoom
Copy link
Contributor Author

👍 Closing.

@pixelzoom
Copy link
Contributor Author

whoops, closed the wrong issue.

@pixelzoom pixelzoom reopened this Nov 9, 2015
aaronsamuel137 added a commit that referenced this issue Nov 16, 2015
@aaronsamuel137
separate screen icon ai files, see #178
25695a3
@aaronsamuel137
Copy link
Contributor

Split these out into 2 ai files. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @aaronsamuel137 @ariel-phet