Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equation AccordionBox doesn't properly resize when interactiveEquationNode is partially hidden #192

Closed
arouinfar opened this issue Jun 19, 2023 · 4 comments

Comments

@arouinfar
Copy link

For #180

When all three sliders in the Equation AccordionBox are hidden, the layout does not dynamically change to eliminate the blank space.
equationAccordionBox.interactiveEquationNode.*Slider.visibleProperty

image

Hiding the interactiveEquationNode resizes things as expected, however.
image

@arouinfar arouinfar changed the title Equation AccordionBox doesn't properly resize when all sliders are hidden Equation AccordionBox doesn't properly resize when interactiveEquationNode is partially hidden Jun 19, 2023
@arouinfar
Copy link
Author

Actually, this appears to be a more general issue with the interactiveEquationNode which contains the sliders and an equationNode.
image

Hiding interatctivieEquationNode.equationNode also results in a gap in the layout.
image

@pixelzoom
Copy link
Contributor

Reproduced in master.

@pixelzoom
Copy link
Contributor

Fixed in the above commit. @arouinfar please review, close if OK.

@arouinfar
Copy link
Author

Thanks @pixelzoom. Looks good in master, closing.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants