Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to model.*PointTool to corresponding view element #191

Closed
arouinfar opened this issue Jun 19, 2023 · 7 comments
Closed

Add link to model.*PointTool to corresponding view element #191

arouinfar opened this issue Jun 19, 2023 · 7 comments

Comments

@arouinfar
Copy link

For #180

The Point Tools contain useful information in both the model and the view. It would be helpful to connect view.leftPointTool and view.rightPointTool to their corresponding model elements. I find myself trying to autoselect my way to the model with ctrl and come up with nothing.

This also means we should make the parent view elements phetioFeatured: true so the links show up in the Featured tree.

@pixelzoom
Copy link
Contributor

Done in the above commits, with API change. See Studio tree screenshot below. @arouinfar please review, close if OK.

screenshot_2625

@arouinfar
Copy link
Author

Thanks @pixelzoom. Can you also feature view.*PointToolNode so these links show up in the Featured tree?

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 20, 2023

Can you also feature view.*PointToolNode so these links show up in the Featured tree?

Oh right, duh... you asked for that. Done in the above commits.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Jun 21, 2023
@arouinfar
Copy link
Author

Looks great, thanks!

@arouinfar
Copy link
Author

Rookie mistake, I reviewed with "All" selected.

I see that view.rightPointTool and view.LeftPointTool are featured, but the links aren't showing up because the target elements model.rightPointTool and model.leftPointTool aren't featured, just their children.

Sorry to send this back again @pixelzoom.

@pixelzoom
Copy link
Contributor

Good catch, fixed in the above commits. Back to @arouinfar to verify.

@arouinfar
Copy link
Author

Looks good in master, thanks @pixelzoom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants