Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstrument equationAccordionBox.titleNode #190

Closed
arouinfar opened this issue Jun 19, 2023 · 3 comments
Closed

Uninstrument equationAccordionBox.titleNode #190

arouinfar opened this issue Jun 19, 2023 · 3 comments

Comments

@arouinfar
Copy link

For #180

In #187 Text and RichText were uninstrumented, including things like titleText. However, it looks like @pixelzoom may have missed one:

exploreScreen.view.equationAccordionBox.titleNode
image

There isn't any reason to instrument this titleNode. Its only child is a read-only visibleProperty whose value never changes.

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 19, 2023

equationAccordionBox.titleNode was uninstrumented throughout in the above commits above. @arouinfar please review, close if OK.

@pixelzoom
Copy link
Contributor

This change also required migration rules (see above commit), which git-hooks did not check for me. Luckily I remembered to check manually using the Migration wrapper. Had I deferred until publishing, this would have been a lot more work to figure out what/where went wrong.

@arouinfar
Copy link
Author

Thanks @pixelzoom, looks good. Glad you tested things out in the Migration wrapper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants