-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
factor out constants for option and var values #107
Comments
Mentioning @samreid, since we had discussed the potential benefit of this on Slack, in relation to phetsims/tandem#71. I tried factoring out constants for the default option values identified in #107 (comment). I did only the ones that are checked in that list, focusing on the classes that are instantiated more than once. Here are the heap snapshots on Chrome 70.0.3538.77 + macOS 10.11.6,
Since there is no obvious memory reduction, I'm not going to commit the changes. |
Reopening. I think I might commit some of this anyway. |
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Creating this issue after a Slack discussion with @samreid.
Some option and var values that could be factored out as constants. Cumulatively these might make a bit of a difference in memory footprint.
More that 1 instance of these is created (number of instances in parens):
Only 1 instance of these is created:
The text was updated successfully, but these errors were encountered: