edit and add review comments, see #43

phetsims · Nov 6, 2018 · da5bebe · da5bebe
1 parent d9edd06
commit da5bebe
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/js/standardform/model/StandardFormModel.js b/js/standardform/model/StandardFormModel.js
@@ -48,8 +48,8 @@ define( require => {
         phetioStudioControl: false
       };
 
-      //REVIEW: Since aProperty is duplicated in VertexFormModel.js, should there a comment that notes they should stay in sync?
-      // coefficients for standard form
+      //REVIEW: Since aProperty is duplicated in VertexFormModel.js, should there be comments that note that the
+      //documentation should stay in sync?
       const aProperty = new NumberProperty( A_RANGE.defaultValue, _.extend( {
         range: A_RANGE,
         tandem: tandem.createTandem( 'aProperty' ),

diff --git a/js/vertexform/model/VertexFormModel.js b/js/vertexform/model/VertexFormModel.js
@@ -51,7 +51,8 @@ define( require => {
       }, coefficientPropertyOptions ) );
       phet.log && aProperty.link( a => { phet.log( 'a=' + a ); } );
 
-      //REVIEW: Since h and k are duplicated in FocusAndDirectrixModel.js, should there be comments that note they should stay in sync?
+      //REVIEW: Since h and k are duplicated in FocusAndDirectrixModel.js, should there be comments that note that
+      //the documentation should stay in sync?
       const hProperty = new NumberProperty( H_RANGE.defaultValue, _.extend( {
         range: H_RANGE,
         tandem: tandem.createTandem( 'hProperty' ),

diff --git a/js/vertexform/view/VertexFormViewProperties.js b/js/vertexform/view/VertexFormViewProperties.js
@@ -29,6 +29,9 @@ define( require => {
 
       super( options );
 
+      //REVIEW: Since this Property is exactly duplicated in FocusAndDirectrixViewProperties.js, should there be comments
+      //that note that the documentation should stay in sync? Along with the other duplicated view Properties, like
+      //axisOfSymmetryVisibleProperty and coordinatesVisibleProperty.
       // @public
       this.vertexVisibleProperty = new BooleanProperty( true, {
         tandem: options.tandem.createTandem( 'vertexVisibleProperty' ),