Merge branch 'master' of https://github.com/phetsims/graphing-quadratics

phetsims · Nov 5, 2018 · b60c57c · b60c57c
2 parents ae7c496 + 496db6d
commit b60c57c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/js/common/view/GQEquationFactory.js b/js/common/view/GQEquationFactory.js
@@ -44,6 +44,7 @@ define( require => {
       const b = Util.toFixedNumber( quadratic.b, options.bDecimals );
       const c = Util.toFixedNumber( quadratic.c, options.cDecimals );
 
+      //REVIEW: Looks like this same string is built on line 142, should it be a constant for this file?
       // y =
       let equationString = GQSymbols.y + ' ' + MathSymbols.EQUAL_TO + ' ';
 
@@ -211,8 +212,7 @@ define( require => {
       } );
 
       return withBackground( equationNode );
-    }
-    ,
+    },
 
     /**
      * Creates the axis of symmetry equation.

diff --git a/js/common/view/GQViewProperties.js b/js/common/view/GQViewProperties.js
@@ -15,6 +15,7 @@ define( require => {
   const graphingQuadratics = require( 'GRAPHING_QUADRATICS/graphingQuadratics' );
   const Tandem = require( 'TANDEM/Tandem' );
 
+  //Review: I believe this JSDoc should go above the constructor
   /**
    * @param {Object} [options]
    */

diff --git a/js/common/view/PointToolNode.js b/js/common/view/PointToolNode.js
@@ -87,7 +87,7 @@ define( require => {
       // background behind the coordinates, sized to the body so that it shows through the window
       const backgroundNode = new Rectangle( 0, 0, bodyNode.width - 10, bodyNode.height - 10 );
 
-      // Put probe on correct side of body. Move the body, since the probe estabishes the origin.
+      // Put probe on correct side of body. Move the body, since the probe establishes the origin.
       if ( pointTool.probeSide === 'left' ) {
         bodyNode.left = probeNode.right - 1; // -1 for overlap, so you don't see a gap
       }
@@ -212,6 +212,7 @@ define( require => {
 
         allowTouchSnag: true,
 
+        //REVIEW: Blank lines should be added before the two comments in start() unless there is a reason not to.
         // note where the drag started
         start: ( event, listener ) => {
           // Note the mouse-click offset when dragging starts.

diff --git a/js/common/view/VertexCheckbox.js b/js/common/view/VertexCheckbox.js
@@ -42,10 +42,10 @@ define( require => {
       // phetioDocumentation that is appropriate for icon type
       if ( options.phetioDocumentation === undefined ) {
         if ( options.manipulatorIcon ) {
-          options.phetioDocumentation ='checkbox that shows the vertex manipulator on the graph';
+          options.phetioDocumentation = 'checkbox that shows the vertex manipulator on the graph';
         }
         else {
-          options.phetioDocumentation ='checkbox that shows the vertex on the graph';
+          options.phetioDocumentation = 'checkbox that shows the vertex on the graph';
         }
       }