Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game timer keeps running after the last challenge is answered #74

Closed
pixelzoom opened this issue Apr 5, 2017 · 3 comments
Closed

Game timer keeps running after the last challenge is answered #74

pixelzoom opened this issue Apr 5, 2017 · 3 comments
Assignees
Labels

Comments

@pixelzoom
Copy link
Contributor

Game timer keeps running after the last challenge is answered, and doesn't stop until you press Next button. It should stop immediately after answering the last challenge.

@pixelzoom
Copy link
Contributor Author

Fixed. The game timer now stops as soon as the user has made their final guess on the last challenge. If their final guess was correct, they'll see a "Next" button that takes them to the "level completed" screen. If their final guess was incorrect, they'll see a "Show Answer" button before seeing the "Next" button. They are not charged for time incurred in reviewing an incorrect answer to the final challenge.

@pixelzoom pixelzoom assigned phet-steele and unassigned pixelzoom Apr 5, 2017
@pixelzoom
Copy link
Contributor Author

I'm going to mention this issue in dev testing for graphing-slope-intercept (phetsims/tasks#812), since that's how it was uncovered.

@phet-steele Could you please review this in master?

@phet-steele
Copy link
Contributor

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants