Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very slight pointer area overlap with number pickers #124

Closed
KatieWoe opened this issue Feb 13, 2019 · 5 comments
Closed

Very slight pointer area overlap with number pickers #124

KatieWoe opened this issue Feb 13, 2019 · 5 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#286 and phetsims/qa#287
There may be a bit of overlap in the down pointer area of of the numerator and the up arrow of the the denominator. It hasn't caused any problems, and I'm not concerned about it. Documenting Here.
maybeoverlap

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 14, 2019

The problem was that the sim was using the mouseArea defaults for NumberPicker, and those need to be tweaked to support the numerator-over-denominator case. So I've specified custom NumberPicker pointer areas in the above commits. These values apply to all NumberPickers in the sim:

// GLConstants.js
PICKER_OPTIONS: {
  touchAreaXDilation: 26,
  touchAreaYDilation: 4,
  mouseAreaXDilation: 0,
  mouseAreaYDilation: 4
}

Here's how they look for the 3 equation forms, and they will be identical in the game:

screenshot_1060

screenshot_1061

screenshot_1062

First we'll get @amanda-phet's approval. Then we'll have @KatieWoe verify in master.

@amanda-phet
Copy link
Contributor

Looks like a good solution to me. Thanks @KatieWoe and @pixelzoom !

@amanda-phet amanda-phet removed their assignment Feb 14, 2019
@KatieWoe
Copy link
Contributor Author

Confirmed on master

@pixelzoom
Copy link
Contributor

Pending regression testing in 1.3.0-rc.4.

@KatieWoe
Copy link
Contributor Author

Looks good in both rc-4's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants