-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very slight pointer area overlap with number pickers #124
Comments
The problem was that the sim was using the mouseArea defaults for NumberPicker, and those need to be tweaked to support the numerator-over-denominator case. So I've specified custom NumberPicker pointer areas in the above commits. These values apply to all NumberPickers in the sim: // GLConstants.js
PICKER_OPTIONS: {
touchAreaXDilation: 26,
touchAreaYDilation: 4,
mouseAreaXDilation: 0,
mouseAreaYDilation: 4
} Here's how they look for the 3 equation forms, and they will be identical in the game: First we'll get @amanda-phet's approval. Then we'll have @KatieWoe verify in master. |
Looks like a good solution to me. Thanks @KatieWoe and @pixelzoom ! |
Confirmed on master |
Pending regression testing in 1.3.0-rc.4. |
Looks good in both rc-4's |
For phetsims/qa#286 and phetsims/qa#287
There may be a bit of overlap in the down pointer area of of the numerator and the up arrow of the the denominator. It hasn't caused any problems, and I'm not concerned about it. Documenting Here.
The text was updated successfully, but these errors were encountered: