-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slope writing is inconsistent size #114
Comments
They probably have different |
Hmmm... When the sim is first started, the sizes the same, see screenshot below. Then after playing with the sim for awhile, the equation on interactive line becomes smaller. Are you seeing this too @KatieWoe? |
Yes. Now that I refresh, I do. |
Looks like. And now that you mention it, something similar happens at that spot on the other two screens as well, but mostly noticeable when at the undefined spot. |
And in phetsims/qa#278, now that I know more what to look for |
@KatieWoe please verify in master. If it looks OK, then leave this issue open for regression testing in next RC. |
looks good in master |
Pending regression testing in 1.3.0-rc.2. |
Confirmed in both rcs |
This error seems to be back in phetsims/qa#286 and phetsims/qa#287. |
Bummer. #114 and #117 are intertwined. When I made the recent change for #117 (see #117 (comment)), I did test #114, but apparently not well enough. |
Doesn't happen in the first screens, but still happens on game screens. @pixelzoom |
@KatieWoe please elaborate, I don't understand. Lines in the games are not labeled with equations, so how can this issue be relevant to the game screens? |
See explanation #117 (comment) |
OK, thanks. So there's nothing wrong with the size of equations used to label lines on the graph, correct? |
Didn't seem like it |
Pending regression testing in 1.3.0-rc.4. |
I did have a quick question for GL though. I noticed that "not a line" change size depending on what happened before it. I think this was known (#117 (comment)) but I wanted to make sure before I oked the issue. |
Test device:
Dell
Operating System:
Win 10
Browser:
Chrome
Problem description:
For phetsims/qa#277
The words "Slope is ___" on the Slope screen are smaller on the active line then the saved lines. This is most noticeable when you hit save line and the two overlap. Does not occur on published version.
Steps to reproduce:
Screenshots:
Troubleshooting information (do not edit):
Name: Graphing Lines:Graphing Lines
URL: https://phet-dev.colorado.edu/html/graphing-lines/1.3.0-rc.1/phet/graphing-lines_en_phet.html?stringTest=double
Version: 1.3.0-rc.1 2019-01-31 19:26:59 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.81 Safari/537.36
Language: en-US
Window: 1536x731
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}
The text was updated successfully, but these errors were encountered: