Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slope writing is inconsistent size #114

Closed
KatieWoe opened this issue Feb 4, 2019 · 21 comments
Closed

Slope writing is inconsistent size #114

KatieWoe opened this issue Feb 4, 2019 · 21 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 4, 2019

Test device:
Dell
Operating System:
Win 10
Browser:
Chrome
Problem description:
For phetsims/qa#277
The words "Slope is ___" on the Slope screen are smaller on the active line then the saved lines. This is most noticeable when you hit save line and the two overlap. Does not occur on published version.
Steps to reproduce:

  1. Set stringTest=double
  2. Go to slope screen
  3. Hit save line button

Screenshots:
funky
activeissmall

Troubleshooting information (do not edit):

Name: ‪Graphing Lines‬:‪Graphing Lines‬
URL: https://phet-dev.colorado.edu/html/graphing-lines/1.3.0-rc.1/phet/graphing-lines_en_phet.html?stringTest=double
Version: 1.3.0-rc.1 2019-01-31 19:26:59 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.81 Safari/537.36
Language: en-US
Window: 1536x731
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

@pixelzoom
Copy link
Contributor

They probably have different maxWidth values.

@pixelzoom
Copy link
Contributor

Hmmm... When the sim is first started, the sizes the same, see screenshot below. Then after playing with the sim for awhile, the equation on interactive line becomes smaller. Are you seeing this too @KatieWoe?

screenshot_1019

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 4, 2019

Yes. Now that I refresh, I do.

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 4, 2019

It looks like making a vertical line ("Slope is undefined") is the action that makes the interactive line's label reduce its size.

screenshot_1020

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 4, 2019

Looks like. And now that you mention it, something similar happens at that spot on the other two screens as well, but mostly noticeable when at the undefined spot.

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 4, 2019

And in phetsims/qa#278, now that I know more what to look for

@pixelzoom
Copy link
Contributor

@KatieWoe please verify in master. If it looks OK, then leave this issue open for regression testing in next RC.

pixelzoom added a commit that referenced this issue Feb 5, 2019
@pixelzoom pixelzoom assigned KatieWoe and unassigned pixelzoom Feb 5, 2019
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 5, 2019

looks good in master

@pixelzoom
Copy link
Contributor

Pending regression testing in 1.3.0-rc.2.

@KatieWoe
Copy link
Contributor Author

Confirmed in both rcs

@KatieWoe
Copy link
Contributor Author

This error seems to be back in phetsims/qa#286 and phetsims/qa#287.
regress

@pixelzoom
Copy link
Contributor

Bummer. #114 and #117 are intertwined. When I made the recent change for #117 (see #117 (comment)), I did test #114, but apparently not well enough.

pixelzoom added a commit that referenced this issue Feb 18, 2019
pixelzoom added a commit that referenced this issue Feb 18, 2019
@pixelzoom
Copy link
Contributor

@KatieWoe please verify this in master. Check with #117, since they are related.

@KatieWoe
Copy link
Contributor Author

Doesn't happen in the first screens, but still happens on game screens. @pixelzoom

@pixelzoom
Copy link
Contributor

@KatieWoe please elaborate, I don't understand. Lines in the games are not labeled with equations, so how can this issue be relevant to the game screens?

@pixelzoom pixelzoom removed their assignment Feb 18, 2019
@KatieWoe
Copy link
Contributor Author

See explanation #117 (comment)

@pixelzoom
Copy link
Contributor

OK, thanks. So there's nothing wrong with the size of equations used to label lines on the graph, correct?

@KatieWoe
Copy link
Contributor Author

Didn't seem like it

pixelzoom added a commit that referenced this issue Feb 18, 2019
@pixelzoom
Copy link
Contributor

Pending regression testing in 1.3.0-rc.4.

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 19, 2019

I did have a quick question for GL though. I noticed that "not a line" change size depending on what happened before it. I think this was known (#117 (comment)) but I wanted to make sure before I oked the issue.
differentsizes
Will also be seen with stringTest=long

@pixelzoom
Copy link
Contributor

Thanks @KatieWoe. What you're showing above is relevant only to #117, not this issue. Displaying "is not a line" is handled separately from equations.

So if you don't find anything else, feel free to close this issue.

@pixelzoom pixelzoom assigned KatieWoe and unassigned pixelzoom Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants