Skip to content

Commit

Permalink
add dependencies that fail, commented out, #140
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Feb 6, 2024
1 parent 113f626 commit 7237320
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions js/pointslope/view/PointSlopeEquationNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,7 @@ export default class PointSlopeEquationNode extends EquationNode {
// are observing a StringProperty. slopeUndefinedStringProperty is used in this.updateLayout.
const dynamicStringMultilink = Multilink.lazyMultilink(
//TODO https://github.com/phetsims/graphing-lines/issues/140 Adding xText.boundsProperty and yText.boundsProperty to dependencies fails with 'stack size exceeded'.
// [ xText.boundsProperty, yText.boundsProperty, GraphingLinesStrings.slopeUndefinedStringProperty ],
[ GraphingLinesStrings.slopeUndefinedStringProperty ],
() => updateLayout( lineProperty.value )
);
Expand Down
1 change: 1 addition & 0 deletions js/slopeintercept/view/SlopeInterceptEquationNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,7 @@ export default class SlopeInterceptEquationNode extends EquationNode {
// are observing a StringProperty. slopeUndefinedStringProperty is used in this.updateLayout.
const dynamicStringMultilink = Multilink.lazyMultilink(
//TODO https://github.com/phetsims/graphing-lines/issues/140 Adding xText.boundsProperty to dependencies fails with 'stack size exceeded'.
// [ xText.boundsProperty, yText.boundsProperty, GraphingLinesStrings.slopeUndefinedStringProperty ],
[ yText.boundsProperty, GraphingLinesStrings.slopeUndefinedStringProperty ],
() => updateLayout( lineProperty.value )
);
Expand Down

0 comments on commit 7237320

Please sign in to comment.