-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dynamic locale #441
Comments
In phetsims/geometric-optics-basics@633f746, support for geometric-optics-basics was addressed -- it's just the title. That sim has never been published, so has no translations and cannot be tested. |
This sim is up next in the list that @kathy-phet gave me, so increasing priority. |
Published 1.2.0-dev.2 with brands=phet,phet-io as a baseline before doing this work. |
This is done. The only bit that's not supporting dynamic strings in the "Slider Controls" section of the keyboard-help dialog, and that's being tracked in phetsims/scenery-phet#769. Ready for review by @arouinfar. |
Geometric Optics and Natural Selection have roughly the same number of strings (56 vs 55 respectively). But Geometric Optics went a lot faster than Natural Selection phetsims/natural-selection#319 because: |
@pixelzoom I reviewed both sims in Studio, and the dynamic locales look great. I didn't encounter any layout issues when editing strings, and everything was nicely instrumented in the view with |
... similar to what was done in phetsims/natural-selection#319.
This also includes geometric-optics-basics.
The text was updated successfully, but these errors were encountered: