Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen flashes or goes blank when object passes over focal point. #399

Open
KatieWoe opened this issue Mar 22, 2022 · 28 comments
Open

Screen flashes or goes blank when object passes over focal point. #399

KatieWoe opened this issue Mar 22, 2022 · 28 comments
Labels
priority:5-deferred type:bug Something isn't working

Comments

@KatieWoe
Copy link

For phetsims/qa#787. This was seen on iPadOS 15.4 in the XHTML sim. However, I haven't been able to reproduce, even on the same device after the page was reloaded. As such, I'm not sure if this is device or XHTML specific.

When dragging the pencil object over the focal point in the first scene on the first screen, the screen would go completely blank while the object passed/rested over that point. I'm sorry I haven't been able to reproduce. If I see it again or find a good way to reproduce it I will update this issue.

IMG_0098.MOV
@KatieWoe KatieWoe added the type:bug Something isn't working label Mar 22, 2022
@pixelzoom
Copy link
Contributor

I could not reproduce this on my iPad6 with iPadOS 15.3. After updating to iPadOS 15.4, I still cannot reproduce it. So I can't do anything here. @KatieWoe I'm afraid I'll have to assign this back to you to reproduce. If you can't make it happen again, then I think we should close this issue.

@pixelzoom pixelzoom assigned KatieWoe and unassigned pixelzoom Mar 22, 2022
@Nancy-Salpepi
Copy link

I wasn't able to reproduce on the iPad Air 2 with iPadOS 15.3.

@pixelzoom
Copy link
Contributor

Discussed with @arouinfar, and we agree that it seems reasonable to close this issue as "won't fix", since it cannot be reproduced.

@pixelzoom pixelzoom added the type:wontfix This will not be worked on label Mar 28, 2022
@KatieWoe
Copy link
Author

I saw this again in phetsims/qa#799. On iPad but not xhtml. Still not sure of the cause, but reopening in case this needs another look.

@KatieWoe
Copy link
Author

I've managed to reproduce it a few times. I think what might be happening is, if you set a point down on the focus point (the tip of the pencil in the case in the video) then pick it up and drag it over that point the flashing behavior occurs. This may just be on iPads.

@pixelzoom
Copy link
Contributor

@KatieWoe are you seeing this with the same device that you originally reported this problem? Or is this a different iPad?

@KatieWoe
Copy link
Author

This is a different iPad, but with the same OS

@pixelzoom
Copy link
Contributor

I cannot reproduce this on my iPad6 with iPadOS 15.4, running the XHTML version https://phet-dev.colorado.edu/html/geometric-optics/1.2.0-dev.1/phet/xhtml/geometric-optics_all.xhtml. I tried putting the tip of the pencil on the left focal point, then dragging the object across/around the left focal point.

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 20, 2022

@arouinfar @KatieWoe thoughts on how to proceed with this issue? This was previously closed as "won't fix", but @KatieWoe reopened it because she's seeing it on another iPad.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Apr 20, 2022
@pixelzoom pixelzoom removed the type:wontfix This will not be worked on label Apr 20, 2022
@KatieWoe
Copy link
Author

I'm willing to pair at some point if you think it would help. Even though I managed to reproduce it 3 or 4 times, it often takes awhile and I'm not incredibly confident on how it is done. Sorry about that.

@pixelzoom
Copy link
Contributor

What is the model of the 2 iPads on which you've seen this problem? The model can be found in Settings > General > Model Name.

@KatieWoe
Copy link
Author

One is an iPad Air 2. The other is a newer model, but I don't remember exactly what. It is currently with @kathy-phet

@arouinfar
Copy link
Contributor

I am fine with closing this as wont-fix, and it's already been documented in the teacher tips. Up to @pixelzoom if you would like to do more investigation to better understand the issue, though.

@arouinfar arouinfar removed their assignment Apr 20, 2022
@pixelzoom pixelzoom added the type:wontfix This will not be worked on label Apr 25, 2022
@pixelzoom
Copy link
Contributor

Closing again as "won't fix".

@Nancy-Salpepi
Copy link

For phetsims/qa#938 I am seeing this issue with macOS 13.3.1 + safari 16.3. The screen will briefly flash (and sometimes goes blank) when I move an object past the focal point on the Lens Screen. This only happens in safari and only with keyboard nav.
I was also able to reproduce in the published sim.
@arouinfar @pixelzoom since this was closed as "won't fix" I didn't know if I should reopen or not.

Steps:

  1. On the Lens Screen, move all three sliders to minimum values
  2. Using the keyboard, move either a framed object or the arrow back and forth past the focal point
screenflash.mp4
Screenshot 2023-05-09 at 10 38 50 AM

@KatieWoe
Copy link
Author

KatieWoe commented May 9, 2023

Reopening for re-evaluation.

@KatieWoe KatieWoe reopened this May 9, 2023
@arouinfar
Copy link
Contributor

Thanks @Nancy-Salpepi. From my understanding, this happens because the image is formed at infinity when an object is placed precisely at the focal point. I don't believe there is anything we can do here. Since the behavior exists in published, is documented in the Teacher Tips, and hasn't been reported by users, we can continue to do nothing here. @pixelzoom feel free to close if you agree.

@pixelzoom
Copy link
Contributor

pixelzoom commented May 14, 2023

Since #399 (comment) reports that the screen goes totally blank, not just flashes, I think it's worth investigating a bit. My guess is that there's some math operation involving infinity that causes the browser to behave badly on certain platforms. That said...

I cannot reproduce #399 (comment) with macOS 13.2.1 + Safari 16.3. I'll update to macOS 13.3.1 + Safari 16.3 (the reported configuration) and try again.

@pixelzoom
Copy link
Contributor

pixelzoom commented May 15, 2023

I upgraded to macOS 13.3.1 + Safari 16.3 and could not reproduce with master or published (1.1.10).
Then I upgraded to macOS 13.3.1(a) + Safari 16.4 and could not reproduce with master or published.
I'm using a MacBookPro16,1, which is Intel-based.

@Nancy-Salpepi what device are you using to test this? I'm especially interested in the processor type.

@pixelzoom pixelzoom changed the title Possible screen flash when object passes over focus point Possible screen flash when object passes over focal point May 15, 2023
@pixelzoom
Copy link
Contributor

@KatieWoe Since @Nancy-Salpepi is out, do you have info on her test machine that was used to report #399 (comment)? Do you know if it's Intel or M1/M2 ?

@KatieWoe
Copy link
Author

I believe it is M1, but I'm not sure and could very well be wrong. I'm sorry.

@pixelzoom
Copy link
Contributor

pixelzoom commented May 16, 2023

Looking at other issues that @Nancy-Salpepi has created lately, the device reported in the issue template is "MacBook Air M1 chip". So I'm guessing that this issue was reported with same device. Since I have an Intel processor and cannot reproduce, I'll bet that this is specific to M1.

@pixelzoom pixelzoom changed the title Possible screen flash when object passes over focal point Screen flashes or goes blank when object passes over focal point. May 16, 2023
@pixelzoom pixelzoom removed the type:wontfix This will not be worked on label May 16, 2023
@pixelzoom
Copy link
Contributor

This is not blocking for the 1.3 release #278, or for creating the 1.3 release branch. If it's not addressed before publishing 1.3, it will be moved back to the "deferred" state, to be investigated in a future release.

@pixelzoom
Copy link
Contributor

pixelzoom commented May 16, 2023

@KatieWoe Do you access to both Mac Intel and Mac M1 test devices? If so, please test using steps in #399 (comment) on both devices, and verify that this is only reproducing on the M1 device.

@KatieWoe
Copy link
Author

Unfortunately not, Nancy's is the only one we have.

@pixelzoom
Copy link
Contributor

This was not resolved before creating the Geometric Optics 1.3 release branch. Labeling as deferred to revisit for a future release.

@pixelzoom
Copy link
Contributor

@Nancy-Salpepi when you return, please verify what test device (processor) was used for #399 (comment). Then you can unassign this issue.

@Nancy-Salpepi
Copy link

For #399 (comment) I was using a MacBook Air M1 (macOS 13.3.1 and safari 16.3).

I also tested GO 1.3.0-rc.2 with my iMac desktop and saw the flashing when using the arrow keys and WASD keys, but the screen didn't go blank in the time I tested.
Processor: 3.1 GHz Quad-core Intel Core i7
OS and Browser: macOS 10.15.7 + safari 15.6.1

@Nancy-Salpepi Nancy-Salpepi removed their assignment May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:5-deferred type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants