Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise how the visibility of individual labels is handled. #383

Closed
pixelzoom opened this issue Mar 16, 2022 · 1 comment
Closed

Revise how the visibility of individual labels is handled. #383

pixelzoom opened this issue Mar 16, 2022 · 1 comment
Assignees
@pixelzoom
Labels
dev:code-review

Comments

@pixelzoom
Copy link
Contributor

For #374

The implementation of the Labels feature is still overly complicated. In particular, the logic that sets visibility of the labels is complicated and duplicated elsewhere. It should be much simpler -- a label should simply be visible based on whether the Node that it's labeling is visible. I'm going to try that approach.
@pixelzoom pixelzoom self-assigned this Mar 16, 2022
pixelzoom added a commit that referenced this issue Mar 16, 2022
@pixelzoom
connect each label to the visibility of its associated Node, #383
aec7b6b
pixelzoom added a commit that referenced this issue Mar 16, 2022
@pixelzoom
add scene field to all SceneNode classes, #383
3e78f84
@pixelzoom
Copy link
Contributor Author

Done. Much cleaner. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom