Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated numbering of Object labels #380

Closed
pixelzoom opened this issue Mar 15, 2022 · 1 comment
Closed

Duplicated numbering of Object labels #380

pixelzoom opened this issue Mar 15, 2022 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

For #374

Duplication in ArrowObjectSceneLabelsNode and LightObjectSceneLabelsNode:

    options.isNumberedProperty.link( ( isNumbered: boolean ) => {
      if ( isNumbered ) {

        // Object N
        this.setText( StringUtils.fillIn( geometricOpticsStrings.label.objectN, {
          objectNumber: lightObject.opticalObjectNumber
        } ) );
      }
      else {

        // Object
        this.setText( geometricOpticsStrings.label.object );
      }
    } );
@pixelzoom pixelzoom self-assigned this Mar 15, 2022
@pixelzoom pixelzoom changed the title Duplication in ArrowObjectSceneLabelsNode and LightObjectSceneLabelsNode Duplicated numbering of Object labels Mar 15, 2022
@pixelzoom
Copy link
Contributor Author

Done in above commits. Also addressed duplication related to numbering and real/virtual in image labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant