Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move point area options to GOToolNode. #377

Closed
pixelzoom opened this issue Mar 15, 2022 · 1 comment
Closed

Move point area options to GOToolNode. #377

pixelzoom opened this issue Mar 15, 2022 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Mar 15, 2022

For #374

PositionMarkerNode currently has these SelfOptions:

  // pointer areas
  touchAreaDilationX?: number;
  touchAreaDilationY?: number;
  mouseAreaDilationX?: number;
  mouseAreaDilationY?: number;

Consider moving them to GOToolNode, default to zero for GORulerNode.

@pixelzoom pixelzoom self-assigned this Mar 15, 2022
@pixelzoom pixelzoom changed the title Move point area options to GOToolesNode. Move point area options to GOToolNode. Mar 15, 2022
pixelzoom added a commit that referenced this issue Mar 15, 2022
@pixelzoom
Copy link
Contributor Author

This was not doable. The superclass (GOToolNode) has no children, the subclasses are responsible for the "look" of the tool. And since pointer areas rely on localBounds, they must be handled by the subclass, after adding child Nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant