New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated guide "arms" #376

Closed

pixelzoom opened this issue Mar 15, 2022 · 0 comments

Assignees

Labels

dev:code-review

Contributor

pixelzoom commented Mar 15, 2022

For #374

Duplication in GuideNode, factor out ArmNode:

    const incidentArmNode = new Rectangle( fulcrumNode.x, fulcrumNode.y - ARM_HEIGHT / 2, ARM_WIDTH, ARM_HEIGHT, armOptions );
    const transmittedArmNode = new Rectangle( fulcrumNode.x, fulcrumNode.y - ARM_HEIGHT / 2, ARM_WIDTH, ARM_HEIGHT, armOptions );

pixelzoom added the dev:code-review label

pixelzoom self-assigned this

pixelzoom changed the title ~~Duplication in GuideNode~~ Duplicated guide "arms"

pixelzoom added a commit that referenced this issue


          address duplicate 'arms' code in GuideNode, #376

bbdc77f

pixelzoom closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment