Use a single PNG for each framed object.

[pixelzoom]

For the framed object (pencil, etc.) I'm wondering why we have 4 image files for each. For example, for the pencil, we have:

pencilLeftFacingInverted.png
pencilLeftFacingUpright.png
pencilRightFacingInverted.png
pencilRightFacingUpright.png

... which look like this respectively (left to right):

The lighting cues are certainly not being adjusted for perspective (should they be?), so I don't think that's the reason.

Since it's trivial to use rotation and reflection to programmatically create 3 of these images from any 1 of them, I propose that we delete 3 of the PNG files for each framed object.

@arouinfar do see any problems with this proposal?

And since I'm not familiar with the history here, maybe @veillette can clarify, if he's available.

[sarchang]

I don't remember exactly why we didn't programmatically rotate/reflect the images but that sounds like a good plan. Definitely double check with @veillette.

[pixelzoom]

Thanks @sarchang.

[veillette]

It would be possible to reduce it from 4 to 2, but one can't reduced it to a single PNG, in general. Some images do not have horizontal reversal symmetry, so at least two images are required for those. Some images like the pencil, have horizontal reversal symmetry , so all the images could be generated from one PNG for those ones. Martin

…

On Thu, Dec 23, 2021, 12:54 PM Chris Malley ***@***.***> wrote: Thanks @sarchang <https://github.com/sarchang>. — Reply to this email directly, view it on GitHub <#284 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2HTQF4SO7W4SSAQDWACPDUSNV5TANCNFSM5KVIIPRQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[pixelzoom]

Thanks @veillette. I see that now -- the penguin and planet do not have "horizontal reversal symmetry".

[pixelzoom]

I guess I'm going to "do nothing" here. It was potentially going to make #283 and #125 a little easier. But I'll work around it.

Closing.